Fix domain validation rejecting valid domains (#113)#114
Merged
Conversation
Validate each domain label independently (alphanumeric plus hyphens, not leading/trailing) and restrict only the TLD to letters. Fixes domains like test.app1e.com being rejected. Closes #113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #113.
isValidDomainrejected several valid domains, e.g.:test.app1e.com— a subdomain label containing a digitx.ioRoot cause
The previous regex only allowed alphanumerics in the first label and restricted every following label to letters only (
(?:\.[a-zA-Z]{2,})+). So any non-first / non-TLD label containing a digit (app1e) was rejected, and the first label was forced to be at least 3 characters.Fix
Validate each label independently (alphanumeric plus hyphens, no leading/trailing hyphen, max 63 chars) and restrict only the TLD to letters:
Verification
test.app1e.com,app1e.kr,x.io,a.b.c.example.com,1example.com,https://test.app1e.com,example.co.ukexample., `-bad.com`, `bad-.com`, `a..b.com`, `example.123`npm run buildpasses