Skip to content

Bootstrap 3 upgrade - #89

Open
JonasHillerDkd wants to merge 12 commits into
ckan:masterfrom
dkd:bootstrap-3_upgrade
Open

Bootstrap 3 upgrade#89
JonasHillerDkd wants to merge 12 commits into
ckan:masterfrom
dkd:bootstrap-3_upgrade

Conversation

@JonasHillerDkd

Copy link
Copy Markdown

Edit the template files for the bootstrap 3 compatibility.

@amercader

Copy link
Copy Markdown
Member

That's great @JonasHillerDkd ! One thing that will happen though is that the templates won't render properly for those users using Bootstrap 2. Given than most changes are class renames perhaps a simple approach would be to add both bootstrap 2 and 3 class names, as each version will ignore the other one's. Happy to consider other approaches too

@JonasHillerDkd

Copy link
Copy Markdown
Author

Hello amercader,

actually you are right with this:

Given than most changes are class renames perhaps a simple approach would be to add both bootstrap 2 and 3 class names, as each version will ignore the other one's.

But i added a new css class and edited the template file base_form.html. I guess that the template editing will not be compatible with Bootstrap 2.

Kind regards
Jonas

Minh-Thien Nhan and others added 6 commits April 22, 2020 12:13
This fixes situations where some IUploader implementations may return an absolute HTTP URL as the `image_url` after uploading. This changes the logic to only prefix URLs with the static URL if they are not already absolute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants