Skip to content

chore(schema): re-vendor embedded manifest schema from canonical - #867

Closed
ZacxDev wants to merge 1 commit into
mainfrom
automation/revendor-canonical-schema
Closed

ZacxDev wants to merge 1 commit into
mainfrom
automation/revendor-canonical-schema

Conversation

@ZacxDev

@ZacxDev ZacxDev commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Automated by the revendor-canonical-schema workflow
(scripts/revendor-canonical-schema.sh).

The canonical block-manifest schema published at
https://civitai.com/schemas/app-block/v1.json changed, so the CLI's
go:embedded mirror (schema/app-block.manifest.schema.json) drifted
and check-canonical-schema would go red. This PR re-vendors the
embedded copy from the canonical.

Validated in the job before opening: the re-vendored schema compiles
under the CLI's jsonschema engine and the bundled example manifests
still validate against it (go test ./...).

Reviewer heads-up: this bot only re-vendors the schema bytes
and records which author-facing pattern glosses that leaves owed. If
the canonical change added a field with author-facing semantics
(e.g. a new manifest key), consider whether internal/validate/ (the
Go semantic checks / friendly messages) should track it too — that
part is a deliberate human call.

⚠️ 1 schema pattern(s) now have no author-facing gloss (^[a-z][a-z0-9_]{0,31}$). An author who trips one gets the bare regex back — correct but terse. The debt is recorded in internal/validate/pattern_gloss_owed.json; clear it by writing the gloss in internal/validate/pattern.go. This PR is still safe to merge as-is.

@ZacxDev

ZacxDev commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #868. This branch's schema is byte-identical to current main (its additions already landed via #865), and it predates the canonical's cross-app storage imports (civitai web v5.1.425): storage.imports, collection exportable, and the apps:storage:import scope. #868 re-vendors from the live canonical with scripts/revendor-canonical-schema.sh and adds a fork-manifest test.

@ZacxDev ZacxDev closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant