Repository navigation
Conversation
Contributor
Author
|
Superseded by #868. This branch's schema is byte-identical to current main (its additions already landed via #865), and it predates the canonical's cross-app storage imports (civitai web v5.1.425): storage.imports, collection exportable, and the apps:storage:import scope. #868 re-vendors from the live canonical with scripts/revendor-canonical-schema.sh and adds a fork-manifest test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by the
revendor-canonical-schemaworkflow(
scripts/revendor-canonical-schema.sh).The canonical block-manifest schema published at
https://civitai.com/schemas/app-block/v1.json changed, so the CLI's
go:embedded mirror (
schema/app-block.manifest.schema.json) driftedand
check-canonical-schemawould go red. This PR re-vendors theembedded copy from the canonical.
Validated in the job before opening: the re-vendored schema compiles
under the CLI's jsonschema engine and the bundled example manifests
still validate against it (
go test ./...).Reviewer heads-up: this bot only re-vendors the schema bytes
and records which author-facing pattern glosses that leaves owed. If
the canonical change added a field with author-facing semantics
(e.g. a new manifest key), consider whether
internal/validate/(theGo semantic checks / friendly messages) should track it too — that
part is a deliberate human call.
^[a-z][a-z0-9_]{0,31}$). An author who trips one gets the bare regex back — correct but terse. The debt is recorded ininternal/validate/pattern_gloss_owed.json; clear it by writing the gloss ininternal/validate/pattern.go. This PR is still safe to merge as-is.