Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by the
bump-scaffold-pinsworkflow (internal/scaffold/cmd/bump-pins).One or more
@civitai/*packages published a new minor, so ascaffold's pre-1.0 caret pins fell behind npm and the
pins-vs-publishedguard would go red. This PR rewrites the staleliteral pins wherever they appear:
internal/scaffold/templates/page-money/package.json.tmplinternal/scaffold/scaffold_test.go(page-money'smustContaincanary)internal/scaffold/templates/page-elements/package.json.tmplinternal/scaffold/page_elements_test.go(page-elements' pin canary)and regenerates
internal/scaffold/testdata/design-tokens.txt(thedesign-token ledger) when the
@civitai/blocks-reactpin or itstoken set moved, or the ledger is missing.
The pins are rewritten as literals (not templated) on purpose:
the guard reads the raw
^X.Y.Zbytes out of the.tmpl, sotemplating the value would blind it.
CI note: this PR is opened with a scoped fine-grained token
(
secrets.BUMP_SCAFFOLD_PINS_TOKEN, Contents + Pull requests RW onthis repo only), not the default
GITHUB_TOKEN— so the repo'snormal checks (
pins-vs-published/scaffold-currency) DO run onit. As defense-in-depth the bump job RUNS three checks before opening
the PR — the network guard (
CIVITAI_CHECK_PUBLISHED_PINS=1 go test -run TestScaffoldPinsSatisfyPublished), the full offline scaffoldsuite, and a fresh
civitai app initscaffold that installs,typechecks and builds against the bumped SDK (which is what would
catch a removed/renamed export).
The first two must pass or this PR is not opened at all. The third
does NOT block it — a failure there opens this PR as a draft
instead, because withholding the bump keeps
mainred and blocks everyPR that touches a pin input (#530 was the whole repo, before that was
narrowed).
Its result for this run is stated on the last line below; do not read
"the bump job validates" as "everything passed".
Scaffold build validation:
success.