feat: resolve managed owner-global items - #10
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:M
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| const vaultRow = { | ||
| id: vaultId, | ||
| attribute_version: 1, | ||
| content_version: 2, | ||
| created_at: "2026-08-21T00:00:00Z", | ||
| updated_at: "2026-08-21T00:00:00Z", | ||
| items: 2, | ||
| format_version: 1, | ||
| overview: await encryptJson( | ||
| { name: "github.com/circlesac", description: "", type: "USER_CREATED" }, | ||
| key, | ||
| `cvlt:v1:vault:${vaultId}:overview` | ||
| ), | ||
| wrapped_vault_key: null, | ||
| kms_wrapped_vault_key: { | ||
| version: 1, | ||
| algorithm: "RSA-OAEP-3072-SHA256", | ||
| ciphertext: "wrapped", | ||
| }, | ||
| coordinate: { provider: "github.com", owner: "circlesac", repository: null }, | ||
| } |
There was a problem hiding this comment.
Suggestion: This fixture does not model the service-managed plain vault described by the test: it omits content_mode, supplies an encrypted overview, and provides a KMS-wrapped key. The test therefore exercises the E2EE locator path and cannot catch the production failure where vaultKey is called for a real plain vault. Mark the vault row as plain and remove the encryption-only key material so the test covers the intended path. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Regression test misses plain-vault key handling.
- ❌ Intended service-managed coordinate behavior remains untested.
- ⚠️ Future implementation changes may pass incorrectly.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** node/src/e2ee-client.test.ts
**Line:** 220:240
**Comment:**
*Incomplete Implementation: This fixture does not model the service-managed plain vault described by the test: it omits `content_mode`, supplies an encrypted overview, and provides a KMS-wrapped key. The test therefore exercises the E2EE locator path and cannot catch the production failure where `vaultKey` is called for a real plain vault. Mark the vault row as plain and remove the encryption-only key material so the test covers the intended path.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| for (const row of rows) { | ||
| candidates.push({ vault_id: row.id, locator: await itemLocator(await vaultKey(config, row, fetchOidcToken), name) }) | ||
| const plain = (await itemRows(config, row.id)).find((item) => | ||
| item.content_mode === "plain" && item.title === name | ||
| ) | ||
| if (plain) candidates.push({ vault_id: row.id, item_id: plain.id }) | ||
| } |
There was a problem hiding this comment.
Suggestion: Plain service-managed vaults do not have an E2EE vault-key envelope, so this unconditional vaultKey call throws before the newly added plain-item candidate can be discovered. Skip the locator candidate for row.content_mode === "plain" and only query item summaries for that vault. [api mismatch]
Severity Level: Critical 🚨
- ❌ Service-managed coordinate reads fail before item resolution.
- ❌ GitHub Actions secret reads cannot resolve plain items.
- ⚠️ `/v1/coordinates/read` receives no plain-item candidate.Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** node/src/e2ee-client.ts
**Line:** 824:830
**Comment:**
*Api Mismatch: Plain service-managed vaults do not have an E2EE vault-key envelope, so this unconditional `vaultKey` call throws before the newly added plain-item candidate can be discovered. Skip the locator candidate for `row.content_mode === "plain"` and only query item summaries for that vault.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix1 participant
User description
Closes circlesac/padawan#195
Changes
Testing
Notes
CodeAnt-AI Description
Resolve service-managed plain items from owner-global references
What Changed
cvlt read vlt://…can now resolve plain items managed by a private service in owner-global VaultsImpact
✅ Plain service-managed items resolve from owner-global references✅ Project-specific values continue to take precedence✅ Secret names stay out of coordinate read requests💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.