chore: migrate biome.json to 2.x schema#517
Conversation
Root pins @biomejs/biome@^2.4.15 but biome.json still used the 1.8.3 schema, so biome 2.x refused to parse it (`files.ignore` was renamed to `files.includes` with negated globs). This broke `code:fix` and the per-package `lint` scripts entirely. Migrated via `biome migrate` and adopted biome's recommended folder-ignore form for nix/store. Faithful config migration only — no rule or behavior changes, and biome is not run in CI so this has no pipeline impact.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesBiome Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Now that biome.json parses under biome 2.x (#517), run `biome check --write` to clear the backlog of auto-fixable findings that were invisible while the config was unparseable. Safe fixes only — formatting reflow plus safe lint fixes (import sorting, etc.). The 351 unsafe fixes and the remaining non-autofixable lint findings are intentionally left for manual follow-up. Mechanical change; no behavior change. Verified: CLI suite (312 tests) and script self-tests (20) pass; reformatted packages with credential-free unit tests pass; the remaining monorepo test failures are pre-existing DB-integration tests (Missing DATABASE_URL) that fail identically on the base branch.
Problem
Root
package.jsonpins@biomejs/biome@^2.4.15, butbiome.jsonstill declared the 1.8.3 schema. biome 2.x renamedfiles.ignore→files.includes(with negated globs), so the installed biome refuses to parse the config at all:This breaks every biome entry point locally —
pnpm code:fix(biome check --write) and the per-packagelintscripts (biome check .) all fail before checking a single file. The binary was bumped to 2.x without migrating the config.Fix
Ran
biome migrateto convert the config to the 2.4.15 schema:$schema→2.4.15files.ignore: [...]→files.includes: ["**", "!...", ...](biome 2.x's negated-glob form)!**/nix/storeinstead of!**/nix/store/**)Faithful, behavior-preserving config migration — no lint rule changes.
biome check biome.jsonnow validates with zero warnings.Scope / impact
lint:*steps are custom node scripts, not biome) — this only restores the local dev tooling.biome check --writefor the auto-fixable formatting/import-sort changes, plus manual review of the rest — is intentionally out of scope for this config fix and should be a follow-up.Verification
biome check biome.json→ valid, 0 warningsbiome checknow runs across the repo (previously crashed on config parse)Summary by CodeRabbit