Conversation
…page An audit of the Analysis page (#311) found fifteen faults, several of which put wrong numbers in front of the user. The histogram lost the frame at the maximum value because the last bin edge was accumulated in floating point and landed below it; the last bin now ends exactly at the maximum and counts always sum to the sample size. The Compare verdict divided by the smaller median while describing the smaller group as "X% lower", so it printed figures above 100 percent; it now divides by the larger median. The correlation verdict assumed lower is always better, which read backwards for detected stars; wording now follows each metric's polarity and stays neutral for ADU metrics. The Time Series tooltip named an arbitrary target on multi-target nights and now lists the targets. Pixel HFR plotted across rigs with different plate scales now raises a visible warning on every tab that plots it. The 95% confidence band uses the Student t value for the sample size instead of a fixed 2.0, so it is no longer under half its correct width on small samples. Correlation coefficients report n/a rather than 0.0 when there are too few points or a constant axis, matching the matrix. Box plot months group by imaging night like every other grouping, groups dropped for having fewer than four frames are listed under the chart, and "not enough data" errors from the API are shown instead of an empty chart. Queries feeding figures are now ordered, so identical requests return identical results and the same downsampled points. Outlier fences are computed once per request instead of re-sorting both axes per point, skewness uses full-precision inputs, and two unreachable branches are gone. Help texts for Matrix, Time Series, Granularity and the date range now describe what the page does. The OpenAPI export and generated types are refreshed, which also picks up endpoints added since the last export.
Analysis Page Data and Text Corrections
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
What's fixed