perf(tui): coalesce rapid input redraws - #338
Open
Andiveli wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coalesce rapid input redraw requests behind a 12 ms deadline while preserving synchronized media-animation and stale-placement cleanup transactions.
Why
Related to #332 as an independent performance follow-up. This branch is based directly on current
main, does not depend on the guild-icon feature chain, and changes no guild-icon files.How
Keep the earliest pending redraw deadline, shorten a background deadline when input arrives, and consume media-animation requests in the redraw plan. The change is limited to the redraw scheduler and runtime integration.
Testing
cargo fmt --all --checkgit diff --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all-features(1,743 library tests passed, 1 binary test passed, 1 ignored)Chain context
Start: current
main. End: rapid input no longer replaces the existing redraw deadline, while media cleanup remains synchronized. Follow-up: none required for #332. Out of scope: guild icon state, media, and rendering.Screenshots or recordings
Not required; this is a timing/behavior optimization.
Checklist
README.md, if behavior or workflows changed (not required for this internal timing optimization).