feat(discord): track guild icon hashes - #333
Open
Andiveli wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
CI is failing on an unchanged upstream expression in |
Contributor
Author
|
The branch is now updated onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the unused guild icon URL helper and its focused tests out of the state-only boundary, preserving guild icon hash parsing and state behavior. The helper is restored in the final rendering boundary.
Why
Related to #332. The previous state head
c432ee1failed CI becauseguild_icon_urlwas not consumed there. This correction keeps the published history intact and aligns the helper with its first visible renderer consumer.How
The new state head
a291844removes only the unused helper and tests. Compact, media, and render branches were advanced with normal merge commits, and render head8927eebrestores the helper, tests, and existing re-export. No rebase or force-push was used.Testing
cargo fmt --all --checkgit diff --checkcargo clippy --all-targets --all-features -- -D warningscargo clippy --all-targets --all-features -- -D warningscargo test --all-features, 1,746 library tests passed, 1 ignored, plus 1 binary testChain context
Start: current
upstream/main. End: guild payload/state and icon hashes are available. Follow-up branches own compact geometry, media loading, URL construction, and rendering.Screenshots or recordings
Not applicable; no visible behavior changes in this boundary.
Checklist
README.md, if behavior or workflows changed (not required for this data-only boundary).