Repository navigation
Fix the §D execution-inputs test timing out in CI - #12
Merged
Merged
Conversation
The first test in "resource-to-slot matching" built a cold ts.Program inside the test body: about 4.5s on its own, and it overran vitest's 5s default on a loaded CI runner (main, Node 22.18.0). The three tests that read that project now share one build in a beforeAll with a 30s timeout. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dd8yB5VfezQ3ymwdwAkixZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Alex · project thread
CI on
main(run 40142914765) failed in the Node 22.18.0 unit-test job:execution-inputs.test.ts > resource-to-slot matching (§D) > offers a resource on every slot its type fits, and only thosehit vitest's 5s default timeout. The other 1717 tests passed, and the same test passed on Node 26.The failure has nothing to do with the commit that triggered it. That test is the first one to build the
opaque-param+odin.playgroundproject, and it pays for a coldts.Programinside the test body. That takes about 4.6s when run on its own locally, so on a loaded runner it goes over 5s.The fix: the three §D tests that only read that project now share one build, done in a
beforeAllwith a 30s timeout. No assertions changed.Verified locally: the file passes (22/22), the full
npm testpasses (1718/1718), andnpm run typecheckis clean.Generated by Claude Code