Conversation
…s match nothing Set-level filters (type, vote, time) previously made a day's group vanish entirely once its sets were filtered out, which unmounted the filter sheet mid-interaction if it was opened from that day's header and made "no matches today" indistinguishable from "this day doesn't exist". Build one group per day from filterScheduleDays' output (which already keeps non-matching days with empty stages) and show an empty-state line instead of dropping the header. The day picker still narrows to the selected day. Closes UPL-64 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bftBYh39JGWmEMUSJ2xdY
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Fixes schedule list filtering so empty day groups remain visible with an appropriate empty state.
Changes:
- Preserves filtered day headers and selected-day behavior.
- Adds per-day empty-state messaging.
- Updates E2E coverage.
File summaries
| File | Change |
|---|---|
tests/e2e/schedule-type-filter.spec.ts |
Tests empty days and filter-sheet persistence. |
src/routes/festivals/$festivalSlug/editions/$editionSlug/schedule/list.tsx |
Builds groups from filtered schedule days. |
src/pages/EditionView/tabs/ScheduleTab/list/ListDayGroup.tsx |
Renders the per-day empty state. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Playwright test resultsDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set-level filters (type, vote, time-of-day) in the schedule list view used to make a whole day group disappear once its sets were filtered out, which also unmounted the filter sheet mid-interaction if it was opened from that day's header. Each day group now comes from
filterScheduleDays's output directly (its contract already keeps non-matching days with empty stages), and empty groups show a "No sets match your filters." line instead of vanishing. The day picker still narrows to just the selected day.UPL-64
Verification
tests/e2e/schedule-type-filter.spec.ts,schedule-list-day-header.spec.ts,schedule-filter-sheet.spec.ts,schedule-vote-chips.spec.ts,schedule-vote-scope.spec.ts(13 tests) all pass locally; full unit suite (655 tests) passes; lint and typecheck clean.Note: self code-review flagged the day-selection filter (
selectedDay === "all" ? days : days.filter(d => d.date === selectedDay)) as now duplicated a third time (existing copies inTimelineToolbar.tsxandScheduleLineupView.tsx). Left as-is here to keep this fix scoped to the two files the issue named — consolidating into a shared helper inscheduleFilter.tswould be a reasonable follow-up touching unrelated call sites.🤖 Generated with Claude Code
https://claude.ai/code/session_011bftBYh39JGWmEMUSJ2xdY
Generated by Claude Code