docs: host the meeting notes example images in the docs - #1815
Conversation
Template_MeetingNotes embedded its two screenshots and demo GIF from an external personal file host. Commit them under Images/examples so the site serves its own images. Amp-Thread-ID: https://ampcode.com/threads/T-01a0df48-b10a-71ff-bdb9-a74681bbf152 Co-authored-by: Christian Bager Bach Houmann <christian@bagerbach.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe meeting notes example now loads its settings screenshot, result screenshot, and project-update demo from local image assets. ChangesMeeting notes example
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The three images now use local assets, and the references resolve correctly. No actionable merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops past notes in flight, Comment |
Deploying quickadd with
|
| Latest commit: |
8bb3fd9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6aca8fbd.quickadd.pages.dev |
| Branch Preview URL: | https://docs-host-meeting-notes-imag.quickadd.pages.dev |
Summary
docs/src/content/docs/docs/Examples/Template_MeetingNotes.mdembedded its two screenshots and its demo GIF fromfiles.bagerbach.com, an external personal file host. Images used by the docs site belong in the docs. This PR commits the same files underdocs/src/content/docs/docs/Images/examples/and points the page at them:files.bagerbach.com/meeting-open-settings-l3soft9zeju2.pngImages/examples/meeting-open-settings.pngfiles.bagerbach.com/meeting-result-yb8zrgx044ko.pngImages/examples/meeting-result.pngfiles.bagerbach.com/project-update-demo-avxs1h3l2buy.gifImages/examples/project-update-demo.gifThe files are byte-for-byte the ones that were already published, and the alt text is unchanged. After this PR, nothing under
docs/referencesfiles.bagerbach.com(git grepis empty).Checks
docs/:pnpm run buildpassed. Astro now optimizes the images into/_astro/*.webp, the same as the page's other local images. The GIF stays animated (95 unique frames), matching how the existingmoviescript.gifis handled.<img>elements loaded (complete: true, natural widths 1272, 1280 and 1280), and the meeting-note screenshot renders correctly in the page.Release / migration impact
Docs only. The slug and URLs are unchanged.
Note
Host meeting notes example images in docs instead of external URLs
Adds three example assets (meeting settings screenshot, meeting result screenshot, project update demo) under docs/src/content/docs/docs/Images/examples/ and updates Template_MeetingNotes.md to reference them with relative links. The rendered docs page now loads these images from the documentation site itself rather than external hosts.
Macroscope summarized 8bb3fd9.
Summary by CodeRabbit