Skip to content

docs: host the meeting notes example images in the docs - #1815

Merged
chhoumann merged 1 commit into
masterfrom
docs/host-meeting-notes-images
Sep 26, 2026
Merged

chhoumann merged 1 commit into
masterfrom
docs/host-meeting-notes-images

Conversation

@chhoumann

@chhoumann chhoumann commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

docs/src/content/docs/docs/Examples/Template_MeetingNotes.md embedded its two screenshots and its demo GIF from files.bagerbach.com, an external personal file host. Images used by the docs site belong in the docs. This PR commits the same files under docs/src/content/docs/docs/Images/examples/ and points the page at them:

Was Now Size
files.bagerbach.com/meeting-open-settings-l3soft9zeju2.png Images/examples/meeting-open-settings.png 114 KB
files.bagerbach.com/meeting-result-yb8zrgx044ko.png Images/examples/meeting-result.png 29 KB
files.bagerbach.com/project-update-demo-avxs1h3l2buy.gif Images/examples/project-update-demo.gif 295 KB

The files are byte-for-byte the ones that were already published, and the alt text is unchanged. After this PR, nothing under docs/ references files.bagerbach.com (git grep is empty).

Checks

  • docs/: pnpm run build passed. Astro now optimizes the images into /_astro/*.webp, the same as the page's other local images. The GIF stays animated (95 unique frames), matching how the existing moviescript.gif is handled.
  • I opened the built page in a browser: all three <img> elements loaded (complete: true, natural widths 1272, 1280 and 1280), and the meeting-note screenshot renders correctly in the page.
  • Before committing, I checked the images for private content: they contain only made-up demo notes.

Release / migration impact

Docs only. The slug and URLs are unchanged.

Note

Host meeting notes example images in docs instead of external URLs

Adds three example assets (meeting settings screenshot, meeting result screenshot, project update demo) under docs/src/content/docs/docs/Images/examples/ and updates Template_MeetingNotes.md to reference them with relative links. The rendered docs page now loads these images from the documentation site itself rather than external hosts.

Macroscope summarized 8bb3fd9.

Summary by CodeRabbit

  • Documentation
    • Updated the meeting notes example to use locally referenced images for its screenshots and demo.

Template_MeetingNotes embedded its two screenshots and demo GIF from an
external personal file host. Commit them under Images/examples so the
site serves its own images.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0df48-b10a-71ff-bdb9-a74681bbf152
Co-authored-by: Christian Bager Bach Houmann <christian@bagerbach.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T21:14:42.922055Z 8bb3fd9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6923052a-8823-4987-9dd1-c6a44cb0377e

📥 Commits

Reviewing files that changed from the base of the PR and between 82fcd33 and 8bb3fd9.

⛔ Files ignored due to path filters (3)
  • docs/src/content/docs/docs/Images/examples/meeting-open-settings.png is excluded by !**/*.png
  • docs/src/content/docs/docs/Images/examples/meeting-result.png is excluded by !**/*.png
  • docs/src/content/docs/docs/Images/examples/project-update-demo.gif is excluded by !**/*.gif
📒 Files selected for processing (1)
  • docs/src/content/docs/docs/Examples/Template_MeetingNotes.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The meeting notes example now loads its settings screenshot, result screenshot, and project-update demo from local image assets.

Changes

Meeting notes example

Layer / File(s) Summary
Update image references
docs/src/content/docs/docs/Examples/Template_MeetingNotes.md
The settings screenshot, result screenshot, and project-update demo now reference local image assets.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 8bb3f

The three images now use local assets, and the references resolve correctly. No actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 8bb3f

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/src/content/docs/docs/Examples/Template_MeetingNotes.md: The meeting-settings image now uses the local ../Images/examples/meeting-open-settings.png asset instead of an external URL.
  • observed — Modified behavior in docs/src/content/docs/docs/Examples/Template_MeetingNotes.md: The meeting-result image now uses the local ../Images/examples/meeting-result.png asset instead of an external URL.
  • observed — Modified behavior in docs/src/content/docs/docs/Examples/Template_MeetingNotes.md: The project-update demo now uses the local ../Images/examples/project-update-demo.gif asset instead of an external URL.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: hosting the meeting notes example images in the documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops past notes in flight,
Three local pictures shine bright.
The settings view, the results show,
The project demo starts to glow.
Then off the rabbit goes to munch.

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8bb3fd9
Status: ✅  Deploy successful!
Preview URL: https://6aca8fbd.quickadd.pages.dev
Branch Preview URL: https://docs-host-meeting-notes-imag.quickadd.pages.dev

View logs

@chhoumann
chhoumann merged commit 255fd76 into master Sep 26, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants