Skip to content

fix(settings): shorten long dropdown options that crushed their labels - #1808

Merged
chhoumann merged 1 commit into
masterfrom
fix/settings-launcher-dropdown-label
Sep 26, 2026
Merged

chhoumann merged 1 commit into
masterfrom
fix/settings-launcher-dropdown-label

Conversation

@chhoumann

@chhoumann chhoumann commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

Shortens two settings dropdowns whose long options crushed their labels in narrower windows.

A native <select> is as wide as its longest option. "Show at the bottom (keeps your top choice first)" made the launcher-row dropdown 335px wide, and "Show updates only on major releases (new features, breaking changes)" made Announce updates 400px wide. In an 800px window, the launcher row's label and description were squeezed into a 51px column (one word per line, several cut off with ellipses). The Announce updates label was squeezed to 0px, so it disappeared entirely.

The options are now short:

  • "New note from template" in the launcher: Bottom / Top / Hidden
  • Announce updates: Every release / Feature releases / Never. The major tier fires on minor and major bumps (see isFeatureUpdate in main.ts), so "Feature releases" describes it more accurately than "major releases" did.

Only display labels change; stored values (bottom/top/off, all/major/none) are the same, so existing settings are unaffected. docs/.../Settings.md quotes the new option names.

At 800px:

Before After
Launcher row before Launcher row after
Announce updates before Announce updates after

Measured in Obsidian 1.13.7 across every QuickAdd settings row. At 800px these were the only two badly squeezed rows; at 700px Obsidian stacks rows, so they aren't affected.

Regression coverage: tests/e2e/settings-layout.test.ts opens QuickAdd's settings in an 800px window and requires every dropdown row to leave at least half its width to the label. It fails on master (launcher label gets 11.5% of the row) and passes here, and it will catch future long options in any dropdown. The full e2e suite (209), unit tests, and build-with-lint pass locally.

No release or migration impact.

Follow-up to #1806.

Note

Shorten settings dropdown labels that overflowed their row labels

  • Changes the template launcher-row dropdown labels to Bottom, Top, and Hidden, and the update-announcement labels to Every release, Feature releases, and Never, in settingsDefinitions.ts. Option keys and defaults are unchanged.
  • Updates Settings.md to match the new labels and documents Feature releases as the default.
  • Adds an E2E test in settings-layout.test.ts that resizes the window to 800px and asserts each dropdown label area keeps at least half of its row.

Macroscope summarized 4532ab6.

Summary by CodeRabbit

  • Style
    • Shortened the placement options for “New note from template” to “Bottom,” “Top,” and “Hidden,” and update-announcement options to “Every release,” “Feature releases,” and “Never.”
  • Tests
    • Added a check that settings labels remain readable in a narrow window.

A native select is as wide as its longest option. The launcher-row and
Announce updates dropdowns had sentence-long options, so in an 800px
window they squeezed their label and description to one word per line,
or to nothing. The options are now short (Bottom/Top/Hidden and Every
release/Feature releases/Never); stored values are unchanged.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T16:36:14.077108Z 4532ab6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 105e6d15-de96-4641-b391-212e83f022de

📥 Commits

Reviewing files that changed from the base of the PR and between 431cbc2 and 4532ab6.

📒 Files selected for processing (3)
  • docs/src/content/docs/docs/Settings.md
  • src/gui/components/settingsDefinitions.ts
  • tests/e2e/settings-layout.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

Two settings dropdowns now use shorter labels, with their option values unchanged. The settings documentation reflects the label changes. An end-to-end test checks the dropdown row layout at 800px wide.

Changes

Settings labels and layout

Layer / File(s) Summary
Update setting labels and verify layout
src/gui/components/settingsDefinitions.ts, docs/src/content/docs/docs/Settings.md, tests/e2e/settings-layout.test.ts
The launcher options now read “Bottom,” “Top,” and “Hidden.” The update-announcement options now read “Every release,” “Feature releases,” and “Never.” The documentation uses the new labels. An end-to-end test checks that the label area occupies at least half of each dropdown row at 800px wide.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 4532a

The shorter labels address the cramped settings rows without changing saved preferences. No actionable merge-blocking risk is evident after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: shortening long settings dropdown labels to prevent layout problems.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each setting row,
At eight hundred pixels, labels show.
“Bottom” and “Top” now fit the view,
“Every release” joins the queue.
The rabbit hops, the tests run through.

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4532ab6
Status: ✅  Deploy successful!
Preview URL: https://90c247cb.quickadd.pages.dev
Branch Preview URL: https://fix-settings-launcher-dropdo.quickadd.pages.dev

View logs

@chhoumann
chhoumann merged commit 2d84bd9 into master Sep 26, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant