fix(settings): shorten long dropdown options that crushed their labels - #1808
Conversation
A native select is as wide as its longest option. The launcher-row and Announce updates dropdowns had sentence-long options, so in an 800px window they squeezed their label and description to one word per line, or to nothing. The options are now short (Bottom/Top/Hidden and Every release/Feature releases/Never); stored values are unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughTwo settings dropdowns now use shorter labels, with their option values unchanged. The settings documentation reflects the label changes. An end-to-end test checks the dropdown row layout at 800px wide. ChangesSettings labels and layout
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The shorter labels address the cramped settings rows without changing saved preferences. No actionable merge-blocking risk is evident after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each setting row, Comment |
Deploying quickadd with
|
| Latest commit: |
4532ab6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90c247cb.quickadd.pages.dev |
| Branch Preview URL: | https://fix-settings-launcher-dropdo.quickadd.pages.dev |
Shortens two settings dropdowns whose long options crushed their labels in narrower windows.
A native
<select>is as wide as its longest option. "Show at the bottom (keeps your top choice first)" made the launcher-row dropdown 335px wide, and "Show updates only on major releases (new features, breaking changes)" made Announce updates 400px wide. In an 800px window, the launcher row's label and description were squeezed into a 51px column (one word per line, several cut off with ellipses). The Announce updates label was squeezed to 0px, so it disappeared entirely.The options are now short:
majortier fires on minor and major bumps (seeisFeatureUpdateinmain.ts), so "Feature releases" describes it more accurately than "major releases" did.Only display labels change; stored values (
bottom/top/off,all/major/none) are the same, so existing settings are unaffected.docs/.../Settings.mdquotes the new option names.At 800px:
Measured in Obsidian 1.13.7 across every QuickAdd settings row. At 800px these were the only two badly squeezed rows; at 700px Obsidian stacks rows, so they aren't affected.
Regression coverage:
tests/e2e/settings-layout.test.tsopens QuickAdd's settings in an 800px window and requires every dropdown row to leave at least half its width to the label. It fails on master (launcher label gets 11.5% of the row) and passes here, and it will catch future long options in any dropdown. The full e2e suite (209), unit tests, andbuild-with-lintpass locally.No release or migration impact.
Follow-up to #1806.
Note
Shorten settings dropdown labels that overflowed their row labels
Macroscope summarized 4532ab6.
Summary by CodeRabbit