Skip to content

fix(feed/search): parse feed once + content-based search cache #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chhoumann merged 2 commits into from
Jun 29, 2026
Merged

fix(feed/search): parse feed once + content-based search cache #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c4f7ce
fix(feed): parse the feed once per getEpisodes call
chhoumann Jun 29, 2026
c57fae3
fix(search): rebuild the Fuse cache on content change, not just length
chhoumann Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
260 changes: 56 additions & 204 deletions src/parser/feedParser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,18 @@ import { requestWithTimeout } from "src/utility/networkRequest";

const mockRequestWithTimeout = vi.mocked(requestWithTimeout);

// Build the shape requestWithTimeout resolves to. Keeps the per-test mock setup
// to a single line and makes the number of expected fetches obvious at a glance.
function feedResponse(text: string) {
return {
text,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
};
}

const sampleRssFeed = `<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd">
<channel>
Expand Down Expand Up @@ -359,48 +371,27 @@ describe("FeedParser", () => {
});

describe("getEpisodes", () => {
test("parses all valid episodes from feed", async () => {
// getEpisodes now calls getFeed first, then parseFeed again
mockRequestWithTimeout
.mockResolvedValueOnce({
text: sampleRssFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: sampleRssFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
test("parses all valid episodes from a single feed fetch", async () => {
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(sampleRssFeed),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");

expect(episodes).toHaveLength(2);
expect(episodes[0].title).toBe("Episode 1");
expect(episodes[1].title).toBe("Episode 2");
// A cold getEpisodes call must fetch + parse the feed exactly ONCE. It
// previously fetched twice (here, then again inside getFeed), doubling
// the load on the feed host.
expect(mockRequestWithTimeout).toHaveBeenCalledTimes(1);
});

test("parses episode properties correctly and populates feed metadata", async () => {
mockRequestWithTimeout
.mockResolvedValueOnce({
text: sampleRssFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: sampleRssFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(sampleRssFeed),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -418,21 +409,9 @@ describe("FeedParser", () => {
});

test("parses Podcasting 2.0 chapter URLs from episodes (#47)", async () => {
mockRequestWithTimeout
.mockResolvedValueOnce({
text: rssFeedWithPodcastChapters,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: rssFeedWithPodcastChapters,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(rssFeedWithPodcastChapters),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -456,21 +435,7 @@ describe("FeedParser", () => {
</item>
</channel>
</rss>`;
mockRequestWithTimeout
.mockResolvedValueOnce({
text: videoFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: videoFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(feedResponse(videoFeed));

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -495,21 +460,9 @@ describe("FeedParser", () => {
</item>
</channel>
</rss>`;
mockRequestWithTimeout
.mockResolvedValueOnce({
text: audioMp4Feed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: audioMp4Feed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(audioMp4Feed),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand Down Expand Up @@ -544,21 +497,9 @@ describe("FeedParser", () => {
</item>
</channel>
</rss>`;
mockRequestWithTimeout
.mockResolvedValueOnce({
text: untypedAmbiguousFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: untypedAmbiguousFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(untypedAmbiguousFeed),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -571,21 +512,9 @@ describe("FeedParser", () => {
});

test("filters out invalid episodes missing required fields", async () => {
mockRequestWithTimeout
.mockResolvedValueOnce({
text: rssFeedWithInvalidItem,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: rssFeedWithInvalidItem,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(rssFeedWithInvalidItem),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -601,37 +530,23 @@ describe("FeedParser", () => {
artworkUrl: "https://example.com/feed-artwork.jpg",
};

mockRequestWithTimeout.mockResolvedValueOnce({
text: sampleRssFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(sampleRssFeed),
);

// When constructed with a feed, it skips calling getFeed
// When constructed with a feed, it skips re-deriving feed metadata.
const parser = new FeedParser(mockFeed);
const episodes = await parser.getEpisodes("https://example.com/feed.xml");

expect(episodes[1].artworkUrl).toBe("https://example.com/feed-artwork.jpg");
// A pre-populated, matching feed still fetches the items exactly once.
expect(mockRequestWithTimeout).toHaveBeenCalledTimes(1);
});

test("uses episode artwork from itunes:image when available", async () => {
mockRequestWithTimeout
.mockResolvedValueOnce({
text: sampleRssFeedWithItunesImage,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: sampleRssFeedWithItunesImage,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(sampleRssFeedWithItunesImage),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -642,21 +557,9 @@ describe("FeedParser", () => {

describe("episode number and duration (#34, #88)", () => {
test("parses <itunes:episode>/<itunes:duration> with a title fallback", async () => {
mockRequestWithTimeout
.mockResolvedValueOnce({
text: rssFeedWithEpisodeNumberAndDuration,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: rssFeedWithEpisodeNumberAndDuration,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(
feedResponse(rssFeedWithEpisodeNumberAndDuration),
);

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand Down Expand Up @@ -704,21 +607,7 @@ describe("FeedParser", () => {
</channel>
</rss>`;

mockRequestWithTimeout
.mockResolvedValueOnce({
text: emptyFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: emptyFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(feedResponse(emptyFeed));

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -740,21 +629,7 @@ describe("FeedParser", () => {
</channel>
</rss>`;

mockRequestWithTimeout
.mockResolvedValueOnce({
text: minimalFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: minimalFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(feedResponse(minimalFeed));

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -781,21 +656,7 @@ describe("FeedParser", () => {
</channel>
</rss>`;

mockRequestWithTimeout
.mockResolvedValueOnce({
text: cdataFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: cdataFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
mockRequestWithTimeout.mockResolvedValueOnce(feedResponse(cdataFeed));

const parser = new FeedParser();
const episodes = await parser.getEpisodes("https://example.com/feed.xml");
Expand All @@ -805,20 +666,8 @@ describe("FeedParser", () => {

test("getFeed sets internal feed state for subsequent calls", async () => {
mockRequestWithTimeout
.mockResolvedValueOnce({
text: sampleRssFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
})
.mockResolvedValueOnce({
text: sampleRssFeed,
status: 200,
headers: {},
arrayBuffer: new ArrayBuffer(0),
json: {},
});
.mockResolvedValueOnce(feedResponse(sampleRssFeed))
.mockResolvedValueOnce(feedResponse(sampleRssFeed));

const parser = new FeedParser();
await parser.getFeed("https://example.com/feed.xml");
Expand All @@ -827,6 +676,9 @@ describe("FeedParser", () => {
// Episodes should have feed metadata populated
expect(episodes[0].podcastName).toBe("Test Podcast");
expect(episodes[0].feedUrl).toBe("https://example.com/feed.xml");
// One fetch for getFeed, one for getEpisodes: getEpisodes reuses the
// already-cached feed metadata and does NOT re-fetch it.
expect(mockRequestWithTimeout).toHaveBeenCalledTimes(2);
});
});
});
Loading
Loading