feat(player): support video episode playback by chhoumann · Pull Request #209 · chhoumann/PodNotes

chhoumann · 2026-06-17T07:09:31Z

Summary

Adds video episode playback with a <video> media element for direct video enclosures and local vault video files while keeping the existing PodNotes controls, timestamps, playback-rate, volume, queue, and progress persistence behavior.
Infers audio/video media type from RSS enclosure MIME type, URL/file extensions, downloaded/local file paths, and invalidates the feed cache schema so stale cached feed episodes are reparsed.
Keeps transcription audio-only, including stale downloaded/local records, and avoids reusing downloaded media for extensionless URLs when query strings identify different content.

Boundary: this supports direct playable media files (video/* enclosures and local .mp4/.m4v/.mov/.webm/.ogv files). It does not embed third-party video players such as YouTube/iframe pages.

Fixes #78

Validation

npm run lint
npm run format:check
npm run typecheck
npm run build
npm run check:a11y
npm run test (57 files, 621 tests)
PATH="/tmp/podnotes-mkdocs-venv/bin:$PATH" npm run docs:build

Obsidian runtime validation

Isolated worktree vault only: podnotes-codex-78-video via npm run obsidian:e2e -- ....

Runtime: Obsidian 1.12.7 (Electron 39.8.3), macOS/darwin, PodNotes 2.16.0.

Validated in the real rendered Obsidian app:

Local vault video file through the PodNotes file-menu path rendered VIDEO, no audio, mediaType: "video", file path __issue78__/last-local-video.mp4, and persisted playback time 42.
RSS feed with video/mp4 enclosure from a local test feed rendered VIDEO, no audio, source http://127.0.0.1:17878/remote-video.mp4, mediaType: "video", and persisted playback time 37.
npm run obsidian:e2e -- dev:errors reported No errors captured after validation.

Review notes

Adversarial review findings were triaged and fixed:

stale local/downloaded .mp4 records cannot bypass the audio-only transcription path;
extensionless source URLs require exact query matches before a downloaded vault resource is reused.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 117bd913b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cloudflare-workers-and-pages · 2026-06-17T07:23:26Z

Deploying podnotes with Cloudflare Pages

Latest commit:	`0726d85`
Status:	✅ Deploy successful!
Preview URL:	https://0d4a1d94.podnotes.pages.dev
Branch Preview URL:	https://feat-78-video-playback.podnotes.pages.dev

View logs

chhoumann · 2026-06-17T07:25:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d638f6b38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T07:44:37Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2045894af6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T08:02:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ad0e313e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T08:25:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff6a99a0f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T08:42:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 932627ff6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T08:53:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a492e6d65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T09:05:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ca638a2c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T09:41:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d30354037

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T09:54:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a6128948f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T10:10:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c43be9e64d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T10:19:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 442b76b946

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T10:29:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07d602a388

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T10:41:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bab2107c93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T10:51:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8b3bef001

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chhoumann · 2026-06-17T11:05:44Z

@codex review

chatgpt-codex-connector · 2026-06-17T11:13:05Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 0726d8504a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# [2.17.0](2.16.0...2.17.0) (2026-06-22) ### Bug Fixes * behavioral-audit logic and robustness fixes (back-end, 1/2) ([#213](#213)) ([4e2845d](4e2845d)) * **download:** default per-episode download path and migrate empty default ([#183](#183)) ([#186](#186)) ([46a6486](46a6486)) * **download:** prevent Android crash and create missing folders on download ([#178](#178)) ([ecd09d5](ecd09d5)), closes [#113](#113) [#86](#86) [#113](#113) [#86](#86) * **lifecycle:** defer mobile podcast view startup ([#208](#208)) ([8bf9ce4](8bf9ce4)) * **notes:** cap note path length and harden folder creation ([#22](#22), [#87](#87)) ([#192](#192)) ([858e280](858e280)), closes [#87-class](#87) * **playback:** persist listened time during playback ([#33](#33)) ([#190](#190)) ([e3433c2](e3433c2)), closes [#191](#191) [#108](#108) [#163](#163) [#183](#183) * **playback:** play local files and downloads on iOS via resource path ([#100](#100)) ([#184](#184)) ([12c503a](12c503a)) * **player:** clear progress on episode switch to stop end-of-playback glitch ([#94](#94)) ([#194](#194)) ([59dccb3](59dccb3)) * **player:** reveal PodNotes view on Play with PodNotes so local files play ([#84](#84)) ([#198](#198)) ([5953625](5953625)) * **settings:** show labelled Add/Remove buttons in podcast search ([#109](#109)) ([#195](#195)) ([33399f5](33399f5)) * show downloaded episodes in the Local Files playlist ([#176](#176)) ([#177](#177)) ([184188c](184188c)) * **timestamps:** capture into the cursor's table cell without breaking the row ([#165](#165)) ([#203](#203)) ([964e342](964e342)) * **transcription:** always transcribe the currently playing episode ([#182](#182)) ([62b488a](62b488a)), closes [#107](#107) * **uri:** preserve '+' in episode titles and paths for timestamp links ([#181](#181)) ([8ad7aa5](8ad7aa5)), closes [#164](#164) * **view:** reliably reveal PodNotes view via command + ribbon icon ([#55](#55)) ([#199](#199)) ([fa1d708](fa1d708)) ### Features * add podcast segment links ([#205](#205)) ([d97e59e](d97e59e)) * **api:** expose generated episode transcripts ([e264465](e264465)), closes [#105](#105) * behavioral-audit UI and interaction fixes (front-end, 2/2) ([#215](#215)) ([894d93d](894d93d)) * **commands:** add playback rate and media timestamp controls ([#206](#206)) ([a8bb44a](a8bb44a)) * **devx:** isolated per-worktree Obsidian E2E vault wrapper ([#188](#188)) ([a8b7a4a](a8b7a4a)) * **episodes:** add a setting to control the Latest Episodes list length ([#114](#114)) ([#200](#200)) ([7b3e3c6](7b3e3c6)) * **notes:** add {{episodelink}} template tag to resume an episode from its note ([#35](#35)) ([#193](#193)) ([8c1ddd6](8c1ddd6)) * **notes:** add podcast feed-level notes ([#163](#163)) ([#187](#187)) ([db0de47](db0de47)), closes [#161](#161) [#160](#160) * **notes:** ship a Bases-friendly default episode note template ([#160](#160)) ([#201](#201)) ([209431d](209431d)), closes [#163](#163) [#183](#183) * **player:** scale episode title font size to its length ([#81](#81)) ([#202](#202)) ([659b6b8](659b6b8)) * **player:** support video episode playback ([#209](#209)) ([f92a91f](f92a91f)) * **queue:** add setting to disable queue auto-population and auto-advance ([#108](#108)) ([#185](#185)) ([cf3d73c](cf3d73c)) * **queue:** allow reordering the playback queue ([#80](#80)) ([#179](#179)) ([d994d61](d994d61)), closes [#173](#173) * **settings:** import/export settings & templates ([#180](#180)) ([a27d23d](a27d23d)), closes [#162](#162) [#162](#162) * **templates:** add {{currentDate}}, {{episodeNumber}}, {{duration}} template variables ([#189](#189)) ([ec573eb](ec573eb)), closes [#75](#75) [#34](#34) [#88](#88) [163/#186](#186) * **templates:** add episode chapters tag ([#207](#207)) ([9c98863](9c98863)) * **transcripts:** opt-in speaker diarization for transcripts ([#168](#168)) ([#204](#204)) ([a96e12f](a96e12f))

github-actions · 2026-06-22T11:12:31Z

🎉 This PR is included in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat(player): support video episode playback

117bd91

chhoumann linked an issue Jun 17, 2026 that may be closed by this pull request

[FR] Player can play video #78

Closed

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/utility/mediaType.ts Outdated

fix(player): trust explicit audio media metadata

0d638f6

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/utility/mediaType.ts Outdated

fix(player): preserve audio mp4 metadata for downloads

2045894

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/utility/mediaType.ts Outdated

fix(player): trust explicit audio media metadata

8ad0e31

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/downloadEpisode.ts Outdated

fix(transcript): honor explicit audio for generic media downloads

ff6a99a

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/downloadEpisode.ts Outdated

fix(transcript): reuse legacy audio mp4 downloads

932627f

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/ui/PodcastView/EpisodePlayer.svelte Outdated

fix(player): reuse legacy audio mp4 downloads

1a492e6

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/downloadEpisode.ts Outdated

fix(transcript): trust explicit audio for video typed containers

7ca638a

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/utility/mediaType.ts Outdated

Comment thread src/downloadEpisode.ts

fix(media): preserve legacy container handling

3d30354

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/downloadEpisode.ts Outdated

fix(download): reject unsupported video downloads

2a61289

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/downloadEpisode.ts

fix(download): reject blank video downloads

c43be9e

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/utility/mediaType.ts Outdated

fix(media): reuse extensionless signed downloads

442b76b

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/utility/mediaType.ts

fix(local-files): choose ambiguous container playback type

07d602a

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/parser/feedParser.ts Outdated

fix(parser): keep ambiguous enclosure containers audio

bab2107

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/utility/mediaType.ts Outdated

fix(media): preserve stable query identity

e8b3bef

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/downloadEpisode.ts

fix(transcription): infer legacy audio container hints

0726d85

chhoumann merged commit f92a91f into master Jun 17, 2026
2 checks passed

github-actions Bot added the released label Jun 22, 2026

Uh oh!

Conversation

chhoumann commented Jun 17, 2026

Summary

Validation

Obsidian runtime validation

Review notes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying podnotes with Cloudflare Pages

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chhoumann commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 17, 2026 •

edited

Loading