feat(notes): ship a Bases-friendly default episode note template (#160)

[chhoumann]

Summary

Closes #160.

The episode note defaults shipped empty (note.path = "", note.template = ""), which left the "Create episode note" command disabled on a fresh install and gave new users no structured metadata to build Obsidian Bases views on. This PR ships a sensible, Bases-friendly default for both:

• note.path: PodNotes/{{podcast}}/{{title}}.md (matches the existing download.path convention).
• note.template: YAML frontmatter with structured properties Bases can sort, filter, and group on, plus user-fillable tracking fields:

---
type: podcastEpisode
podcast: "{{podcastlink}}"
url: "{{url}}"
date: {{date:YYYY-MM-DD}}
tags:
  - podcastEpisode
status:
rating:
favorite: false
---
# {{title}}

![]({{artwork}})

[Resume in PodNotes]({{episodelink}})

{{description}}

{{podcastlink}} ties each episode to its podcast feed note (the #163 feature) so Bases / Dataview can roll episodes up under their show. The raw {{title}} lives in the body H1, where YAML rules do not apply, so awkward titles never break the frontmatter.

What changed

• src/constants.ts - new note.path / note.template defaults (scoped to the note block only).
• src/TemplateEngine.ts - NoteTemplateEngine now sanitizes the URL tags (url, stream, artwork, episodeurl, episodeartwork, feedurl, feedartwork) with the existing sanitizeUrlForTemplate (strips " and \), mirroring FeedNoteTemplateEngine. This is lossless for well-formed URLs and keeps a quoted scalar like url: "{{url}}" valid. Each tag is guarded with ?? "" so a corrupted data.json can't throw.
• src/settingsMigrations.ts - new migrateNoteSettings, which upgrades the legacy empty note to the new default only when the whole note is the old default (both path and template empty/absent). Any configured field is preserved verbatim, including a deliberately-empty field used to keep note creation disabled.
• src/main.ts - loadSettings applies migrateNoteSettings.
• scripts/provision-obsidian-e2e-vault.mjs - the e2e seed note block now matches DEFAULT_SETTINGS (keeps the seed/DEFAULT_SETTINGS drift test green and seeds the new default for verification).
• src/ui/settings/PodNotesSettingsTab.ts - the note-template placeholder now shows a Bases-friendly frontmatter hint instead of the old Dataview :: style.
• docs/docs/templates.md - documents the new default, an example .base view, and the URL-tag sanitization.

Compatibility / migration impact

Defaults only reach new installs and users who never configured note settings. Existing users are protected:

• The migration fires only when the stored note is exactly the old default ({ path: "", template: "" }). A user who customized either field keeps both fields untouched.
• This deliberately preserves the "custom path + empty template to keep note creation disabled" case (raised in review).
• No storage shape change; the migrated value is re-persisted on the next save (same pattern as the Default download.path is empty, breaking the Download command (writes ".mp3" to vault root, 2nd download fails) #183 migrateDownloadPath).

The URL-tag sanitization changes existing tag output only for malformed inputs (a " or \ in a URL, which valid URLs never contain). For local-file episodes {{url}} is a wikilink; a normal filename is unaffected, and a filename containing a literal " would have its quote stripped (rare; valid YAML is preferred over an exact link in that edge case).

Verification

Gates (Node 22), all green:

npm run lint
npm run format:check
npm run typecheck
npm run build
npm run test        # 466 passing
npm run docs:build  # mkdocs --strict

Real-Obsidian verification in an isolated worktree vault (npm run obsidian:e2e): drove the actual create-podcast-note command for several episodes, including a hostile title/URL (Why "AI": a deep dive: part 2, URL with an embedded quote and backslash) and a no-date episode. Obsidian's properties parser produced clean frontmatter in every case:

• hostile: url: "https://example.com/ep?x=qc", podcast: "[[PodNotes/Podcasts/My Show|My Show]]", tags: [podcastEpisode], status: null, rating: null, favorite: false; the raw title sits only in the body H1.
• no-date: date: null.

Review

Ran a multi-dimension self-review plus two adversarial reviewers. Key fixes that came out of it: the whole-note migration gate (so an intentional empty field is never re-enabled), correcting the example .base to the documented groupBy form (the canonical Bases schema has no sort view key), and qualifying the "valid YAML" claim for hand-edited feed-note paths that contain YAML-hostile characters.

[cloudflare-workers-and-pages]

Deploying podnotes with    Cloudflare Pages

Latest commit:	b698643
Status:	✅  Deploy successful!
Preview URL:	https://3458bb71.podnotes.pages.dev
Branch Preview URL:	https://chhoumann-160-bases-default.podnotes.pages.dev

View logs

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c695f8444a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chhoumann]

@codex review

Rebased onto master (resolved the src/constants.ts overlap with #114, keeping both the new episodeListLimit setting and the note.template default) and addressed your P2 by reverting the URL-tag sanitization to verbatim rendering in NoteTemplateEngine (commit 1d59e3c). Gates are green. Could you take another look?

[chhoumann]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d59e3c41a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chhoumann]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 👍

Reviewed commit: b69864348f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

🎉 This PR is included in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀