fix(imex): flush each tar entry immediately after appending#8370
Closed
link2xt wants to merge 1 commit into
Closed
fix(imex): flush each tar entry immediately after appending#8370link2xt wants to merge 1 commit into
link2xt wants to merge 1 commit into
Conversation
When streaming over the network we don't want to buffer tar entries, but send them immediately. This is an attempt to fix timeout errors on the receiver side when transferring large files that look like Failed to import backup from QUIC stream: Failed to unpack file: failed to unpack `/home/user/.config/DeltaChat/accounts/<uuid>/dc.db-blobs/blobs_backup/$BLOBDIR/<filename>.mp4`: failed to unpack `blobs_backup/$BLOBDIR/<filename>.mp4` into `/home/user/.config/DeltaChat/accounts/<uuid>/dc.db-blobs/blobs_backup/$BLOBDIR/<filename>.mp4`: connection lost: timed out"
Collaborator
Author
|
IIRC flushing iroh streams is a noop, however. |
Collaborator
Author
|
"connection lost" is likely this error, from iroh-quinn 0.13 (permalink pointing to this tag): And "timed out" is this one: Will need to look into max_idle_timout and keep alive interval. Maybe enabling keepalives is solving the problem. |
Collaborator
Author
|
The problem seems to be on the receiver side, and flushing QUIC streams is likely a noop indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When streaming over the network we don't want
to buffer tar entries, but send them immediately.
This is an attempt to fix timeout errors on the receiver side when transferring large files that look like
Failed to import backup from QUIC stream: Failed to unpack file: failed to unpack
/home/user/.config/DeltaChat/accounts/<uuid>/dc.db-blobs/blobs_backup/$BLOBDIR/<filename>.mp4: failed to unpackblobs_backup/$BLOBDIR/<filename>.mp4into/home/user/.config/DeltaChat/accounts/<uuid>/dc.db-blobs/blobs_backup/$BLOBDIR/<filename>.mp4: connection lost: timed out"