Repository navigation
fix: inherit log level changes in wrapped subloggers - #230
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Subloggers created via With previously copied the parent logger struct by value, isolating their log level state from subsequent parent SetLevel calls. This change links subloggers to their parent hierarchy and resolves the active log level dynamically unless explicitly overridden on the sublogger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184
Problem
When creating a sublogger via With, the logger struct was shallow-copied by value. This decoupled the sublogger's level field from the parent logger. Calling SetLevel on the parent logger after sublogger creation did not update the sublogger's active log level.
Solution