Repository navigation
Conversation
Pretty-printed errors (for example oops stack fragments) indent with tabs and often use Windows newlines. The text formatter escaped both, and Lip Gloss then turned remaining tabs into spaces, so the source never lined up. Leave tabs intact and normalize CR before wrapping multiline values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\tand then expanded or dropped by Lip Gloss, so indentation disappeared.\r\n/ leftover\r) are treated as line breaks instead of a literal\r.lipgloss.NoTabConversionso a tab stays a tab.Test plan
go test -count=1 -run TestTextLogger/multiline_value_preserves_tabs .failed on main (\\tline) and passes with this changego test -count=1 -run TestTextLogger/multiline_value_treats_CRLF_as_a_line_break .failed on main (src:\\r) and passes with this changego test -count=1 .passes