test(filter): cover matching and selection helpers - #1108
Open
Qalipso wants to merge 1 commit into
Open
Conversation
The filter package was at 9.5% statement coverage. This covers the parts that do not need a terminal: matchAll, exactMatches, the cursor movement and wrapping (including reversed lists), selection toggling and its limit, selectAll/deselectAll, and defaultKeymap. Coverage goes from 9.5% to 28.3%. No non-test code is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filterpackage is at 9.5% statement coverage. Most of it is the bubbleteaView/Updateloop, but the matching and selection helpers underneath are plain functions and struct methods that can be tested without a terminal.This adds tests for:
matchAllandexactMatches, including case-insensitive matching, the empty search, the preserved choice index, and that the first occurrence of the search term is the one reportedCursorUp/CursorDown: stepping, wrapping at both ends, the reversed-list behaviour, and the no-matches guardToggleSelection, including that it stops atlimitselectAll(stops atlimit, does not double count an already selected item) anddeselectAlldefaultKeymap/ShortHelp/FullHelpCoverage goes from 9.5% to 28.3%. The remainder is
View,UpdateandRun, which need a TTY. No non-test code is changed;go vetandgo test -racepass.