fix(confirm): clear screen on resize to prevent duplicated prompt text - #1091
Open
syf2211 wants to merge 1 commit into
Open
fix(confirm): clear screen on resize to prevent duplicated prompt text#1091syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
When gum confirm renders inline without the alt screen, shrinking or growing the viewport leaves stale wrapped prompt/button lines visible. Clear the screen on WindowSizeMsg and constrain prompt wrapping to the available content width. Fixes charmbracelet#426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a terminal resize artifact in
gum confirmwhere the prompt (and sometimes buttons) appeared duplicated after shrinking and growing the viewport.Motivation
Fixes #426.
gum confirmrenders inline (no alt screen). When the terminal width changes, lipgloss-wrapped prompt lines can leave stale content on screen because the new frame may be shorter than the previous one.Changes
tea.WindowSizeMsgtea.ClearScreenon resize to remove stale wrapped lines before redrawMaxWidthto the prompt based on available content width (terminal width minus horizontal padding)Tests
Result: PASS
Notes