Draft
Conversation
# Conflicts: # .claude/skills/ir-inspect/SKILL.md
After extracting `_plan_call_ad`, `arg_types` (and the first `args` that fed it) were left in `make_ad_stmts!` but never read — the logic moved inside the helper. Remove both dead lines and their comment. Also correct the file-level roadmap comment: the actual section order in the file is 4 → 5(deferred wrappers) → 6(rule derivation) → 7(fwd/pullback assembly), not the 4 → 5 → 6 → 7 that was documented. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
# Conflicts: # docs/src/developer_documentation/ir_representation.md # src/interpreter/bbcode.jl
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
# Conflicts: # src/interpreter/reverse_mode.jl
Type names should be nouns; CallADPlan read as a verb-y bag-of-values.
RuleSelection more honestly names what _plan_call_ad (now _select_rule)
returns -- the resolved rule plus the metadata produced during selection.
Annotate the fields whose types are fixed (args::Tuple, T_pb!!::Type,
output_type::Type); rule_ref stays untyped because it is genuinely
Union{ID, <singleton rule>}.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Five scrutinise findings: 1. Move section-divider comments above docstrings so they no longer break docstring association for create_comms_insts!, lower_cfg_blocks_to_ir, and pullback_ir. 2. Add the missing block_comms argument to forwards_pass_ir and pullback_ir docstrings. 3. Drop redundant pass-through overloads: _ssa_to_ids on QuoteNode/GotoNode and _cfg_to_ssas on QuoteNode -- the fallback already handles them. 4. Inline _flatten_cfg_insts and _primal_stmt_metadata into generate_ir; each was only used once, and the wrapping obscured what the call site was actually computing. 5. Move the unique cases of the ReverseModeCFG.lower_cfg_blocks testset (sort_cfg=false, _insert_before_terminator!, _cfg_phi_nodes, phi-edge cleanup on dead predecessors) into cfg_builder.jl, and drop the testset's basic round-trip case which duplicated cfg_builder.jl coverage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Earlier rewrites converted seven jldoctest blocks to julia-repl, dropping test coverage on the IR-introduction examples. Convert them back and restore the bar / my_factorial labels so chained blocks share state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The previous commit restored jldoctest markers but kept the rewritten expected outputs, which were missing the `intrinsic ` prefix and the `= invoke` spacing that 1.12 prints. Add them back so the doctests pass under the docs CI (which runs on 1.12). Also fix the `Compiler.NewInstruction` / `Compiler.NoCallInfo` show form. Verified with `julia --project=docs docs/make.jl` -- zero doctest failures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates BBCode in favour of Julia’s native IRCode plus a small local helper.
This needs to be split into smaller PRs for a comfortable review.
Do not review, work in progress.
CI Summary — GitHub Actions
Documentation Preview
Mooncake.jl documentation for PR #1152 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR1152/
Performance
Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.