fix: close out the v2 review follow-ups - #119
Merged
Merged
Conversation
LOG_CATEGORY_BY_KIND wrote the debug log header categories a third time, beside TRACE_CATEGORIES and the header itself. Nothing joined them, so a typo would have shipped a timeByKind row a caller cannot read against the debugLevels rows beside it. Declare LOG_CATEGORIES once, in the module CLAUDE.md names as the one home for the categories, and type logCategoryOf against it. Tests lock the list to the header spellings the fixture logs carry, and to the settable categories.
"zero/empty fields omitted" described 1.x. 2.0 returns every governor limit, category and column, including the ones at zero, so a caller can tell "none" from "never measured". The bullet said the opposite of the policy the Tools Reference states ten lines above it.
inspect() pooled every table header into one set, so a "columns" check passed on a column any other table in the response carried. That let a wrong assertion through earlier in this series. Key the headers by table, and make a "columns" check name its one table in "keys". The three slow-operations checks that named no table now name "operations".
lcottercertinia
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three findings from the v2 response-shape review, one commit each.
timeByKind's log categories were bare strings, so a third spelling could appear beside the onedebugLevelsrows carry. They are now typed, and the tests read the spellings back from the fixture log headers. (fix: read-error cause, relative paths, outputDir outside the client roots, SIGTERM #109)columnscheck could pass on a column another table happened to carry. A check now names its table. (perf: tool responses repeat themselves and cost more tokens than the facts require #86)