Skip to content

ci: run the required checks on the merge queue commit - #118

Merged
lcottercertinia merged 3 commits into
mainfrom
ci/merge-group
Aug 12, 2026
Merged

ci: run the required checks on the merge queue commit#118
lcottercertinia merged 3 commits into
mainfrom
ci/merge-group

Conversation

@lukecotter

Copy link
Copy Markdown
Collaborator

Why

No workflow listened for merge_group. The merge queue tests the commit it
builds, then waits for the required checks to report on it — and a check that
does not run on merge_group never reports. So a queued pull request waits
forever. #114 sat in the queue with every pull_request check green.

What

Add merge_group to CI, CodeQL, Workflow Lint and Dependency Review.
publish.yml is release-only and does not belong in the queue.

Dependency Review reads the pull request both for the two commits to compare
and for a place to comment, and a queued run has neither. It now names the
commits from the merge_group event, clones deep enough to hold them, and
posts nothing.

cancel-in-progress is already github.event_name == 'pull_request', so a
queued run is never cancelled. No change needed there.

Testing

actionlint and zizmor run in the Workflow Lint job on this pull request.

No workflow listened for merge_group, so the queue tested a commit that
nothing reported on and every queued pull request waited forever. PR #114
sat in the queue with all pull_request checks green.

Add the event to CI, CodeQL, Workflow Lint and Dependency Review. Dependency
Review reads the pull request for the two commits to compare and for a place
to comment, and a queued run has neither, so it now names the commits from
the merge_group event and posts nothing.
The trigger and the event expressions say what they do, and the why is
plain from them.
@lcottercertinia
lcottercertinia merged commit 7fbbd88 into main Aug 12, 2026
15 checks passed
@lcottercertinia
lcottercertinia deleted the ci/merge-group branch August 12, 2026 14:29
lukecotter added a commit that referenced this pull request Aug 12, 2026
Main squashed #114 and #115, which this branch already carries under the
new tool names, so every conflict keeps this side. The old tool files are
byte-identical to the ones renamed here, so the deletions stand.

The one real change from main is #118: merge_group on the required
workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants