Repository navigation
ssh: remove 74 keys with no matching lab user - #663
Merged
Merged
Conversation
Follow-up to the 2026-09-17 access review (ceph-sepia-secrets PR 1241, ceph-octo-secrets PR 26). 73 of these usernames are now in revoked_users in one of the secrets repos, so their keys would only keep landing in @all.pub: amathew19 arjsharm avilez basnia bengland dachary devansh devanshsingh dpaganel dvincze emmericp enuessle gkyratsas h4iresis hosand ionutbalutoiu iqbalredkhan jarychen jsawaya jschmid julpark kachau karun kchang kevinz kollia levh lmb luisrico markw8973240 mayagilad melissali mer michaelenglishseagate mlatimer mreddem mrfreezeex nshelke ofriedma oliveiradan omergoshen oshrey16 ozeneva pbs1108 pnawracay poonc3 prasad prateek ramartin rdias roysahar rpavani1998 ryg- scarvalhojr shuzhenyi shyukri skrah smithfarm smithp33 submishr sudhanaruna sunny tamil toabctl tshacked vdaloiya vedansh wmcroberts xiaoxichen xuwang yejordan zl31wang zyan mkhanna.pub is the same key as mananxkhanna.pub (Manan Khanna's lab account), so the extra file goes too. Kept: the service keys listed in the onboarding service's KEYS_EXEMPT (backup01, jenkins, jenkins-build, qa_metropolis, rdu2, root_cephbooter, teuthology-ubuntu, teuthologyworker_metropolis, teuthworker) and kbader, who is a managed user on the long-running cluster. Signed-off-by: David Galloway <david.galloway@ibm.com> Assisted-by: Claude Fable 5.1 (claude-fable-5-1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 2026-09-17 access review (ceph-sepia-secrets#1241, ceph-octo-secrets#26).
Every
ssh/*.pubwas compared againstlab_users+admin_usersin both secrets repos on main. 84 files had no matching user:revoked_usersin one of the secrets repos.mananxkhanna.pub, which is Manan Khanna's actual lab account.KEYS_EXEMPTlist (backup01 jenkins jenkins-build qa_metropolis rdu2 root_cephbooter teuthology-ubuntu teuthologyworker_metropolis teuthworker).lab_usersentry, but he is amanaged_usersmember oflong_running_cluster.Deletions are not auto-merged by the validate workflow, so this needs a manual merge;
regeneratethen rebuilds@all.pub.