Add assertions for plot legend titles in bearing overview tests - #259
Open
tlukkezen wants to merge 1 commit into
Open
Add assertions for plot legend titles in bearing overview tests#259tlukkezen wants to merge 1 commit into
tlukkezen wants to merge 1 commit into
Conversation
Add assertions to ensure that soil_properties.test_id is correctly
propagated from the API response and that plot_bearing_overview()
displays the actual CPT name ("name: <test_id>") in the legend title
rather than the fallback "name: unknown".
Covers compression single-CPT results, tension single-CPT results,
and the grouper MaxBearingResult code paths.
https://claude.ai/code/session_01RW9aBjmj37XkwsM2AmgAPH
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Coverage Report for CI Build 24339545496Coverage remained the same at 83.038%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced test coverage for bearing overview plot functionality by adding assertions that verify the legend title contains the expected test ID.
Key Changes
test_multi_cpt_bearing_resultsto extract the figure fromplot_bearing_overview()and assert that the bearing legend title matches the expected format"name: {test_id}"test_multi_cpt_bearing_resultsfor tension resultstest_grouper_results_max_bearingwith identical legend title assertion logicsoil_properties.test_idmatches the expected test IDImplementation Details
The tests now:
plot_bearing_overview()instead of just type-checking itf"name: {test_id}"to ensure proper labeling of bearing capacity plotsThis improves test robustness by validating not just the plot structure, but also the correctness of the legend labeling which is important for plot readability and data traceability.
https://claude.ai/code/session_01RW9aBjmj37XkwsM2AmgAPH