Skip to content

fix: code quality and safety improvements #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: code quality and safety improvements #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/check-duplicates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ async function run() {
}),
}
);
const data = await response.json();
if (!response.ok) throw new Error("Request failed");
const data = await response.json();

if (data.error || !data.embedding || !data.embedding.values) {
console.error("Embedding error:", data.error || "Invalid response");
Expand Down
4 changes: 2 additions & 2 deletions scripts/cleanup-specific-issue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ async function deleteIssueVectors() {
includeValues: false,
includeMetadata: true,
filter: {
issue_number: parseInt(ISSUE_TO_DELETE)
issue_number: parseInt(ISSUE_TO_DELETE, 10)
}
});

Expand All @@ -65,7 +65,7 @@ async function deleteIssueVectors() {

if (listResponse.vectors) {
for (const vector of listResponse.vectors) {
if (vector.metadata?.issue_number === parseInt(ISSUE_TO_DELETE)) {
if (vector.metadata?.issue_number === parseInt(ISSUE_TO_DELETE, 10)) {
vectorsToDelete.push(vector.id);
console.log(` 📌 Found vector via list: ${vector.id}`);
console.log(` Metadata:`, JSON.stringify(vector.metadata, null, 2));
Expand Down
2 changes: 1 addition & 1 deletion scripts/populate-existing-issues.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ async function populateExistingIssues() {
Object.keys(fetchResult.vectors).forEach(vectorId => {
const match = vectorId.match(/issue-(\d+)/);
if (match) {
const issueNum = parseInt(match[1]);
const issueNum = parseInt(match[1], 10);
if (!existingIssueNumbers.has(issueNum)) {
existingIssueNumbers.add(issueNum);
console.log(` ✓ Found existing issue #${issueNum} by ID`);
Expand Down
17 changes: 1 addition & 16 deletions scripts/validate-apis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,19 +157,4 @@ if (args.includes('--help') || args.includes('-h')) {
switch (service) {
case 'pinecone':
validatePinecone().then(result => {
process.exit(result.success ? 0 : 1);
});
break;
case 'github':
validateGitHub().then(result => {
process.exit(result.success ? 0 : 1);
});
break;
case 'gemini':
validateGemini().then(result => {
process.exit(result.success ? 0 : 1);
});
break;
default:
validateAllConnections();
}
.catch(err => console.error(err))