Improve the time taken to validate and analyse large models#1397
Conversation
…taken to collect equivalence ids.
It was in `AnalyserModel::areEquivalentVariables()`. `it2 == mPimpl->mEquivalentVariableCache.end()` never evaluated to `true`.
agarny
left a comment
There was a problem hiding this comment.
Looks good although I have sped up a few things here and there (see commit messages).
I can't see where |
I have taken that bit out now, as this was only part of the investigation phase of this work. |
jmdowrick
left a comment
There was a problem hiding this comment.
Looks OK to me. Some nice changes.
To run the investigation tests set an environment variable
BENCHMARKING_MODEL_ROOTto the root directory of the unzipped contents of the benchmarking files zip in the associated issue.The longer tests are disabled with the DISABLED_ prefix on the test name, remove this prefix to run the test.