Review comments - #102
Open
t-tye wants to merge 1 commit into
Open
Conversation
ccoutant
reviewed
Feb 27, 2025
| It is identified by its address on the call stack (see Section | ||
| {framebase}). The address is referred to as the frame base | ||
| or the call frame address (CFA). The call frame information is used to | ||
| or the <span class="del">call</span> <span class="add">canonical</span> frame address (CFA). The call frame information is used to |
ccoutant
reviewed
Feb 27, 2025
| `DW_AT_data_member_location` and `DW_AT_use_location`)<span class="del"> where the | ||
| object's location is provided as part of the initial stack</span>. | ||
|
|
||
| [ttye: My reading of the DWARF 5 specification is that if the object address is passed on the initial stack, it does not cause there to be a current object, and `DW_OP_push_object_address`. Either the object address is passed implicitly and accessed using `DW_OP_push_object_address`, or it is passed on the stack. It would have been better if one consistent method could have been used in all cases.] |
Owner
There was a problem hiding this comment.
As discussed in the meeting, I think the spec is worded so that the implicit push of the location is equivalent to using DW_OP_push_object_address, and therefore there is a current object in that case.
ccoutant
reviewed
Feb 27, 2025
| This operation pops a location `L` from the stack. The | ||
| first `TS` bits are retrieved from the location `L` and pushed onto the | ||
| stack as a value of type `T`. | ||
| ] |
ccoutant
reviewed
Feb 28, 2025
| the dereferenced address is specified by the first operand. This operand is | ||
| a 1-byte unsigned integral constant whose value | ||
| value which is the same as the size of the base type referenced | ||
| <span class="del">value which</span> is the same as the size of the base type referenced |
Owner
There was a problem hiding this comment.
This fixes a typo in the DWARF 5 spec.
ccoutant
reviewed
Feb 28, 2025
| which the expression is being evaluated (see Section | ||
| {lowlevelinformation}). | ||
| ] | ||
|
|
ccoutant
reviewed
Feb 28, 2025
| *The DWARF expressions in value list entries, being | ||
| expressions and not location descriptions, may not contain | ||
| *The DWARF expressions in value list entries, <span class="del">being | ||
| expressions and</span> not <span class="add">being</span> location descriptions, may not contain |
Owner
There was a problem hiding this comment.
Should just remove this paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.