Repository navigation
fix(sync): process marked boards before reporting batch failures - #2372
Open
jonathanwxh-cell wants to merge 1 commit into
Open
jonathanwxh-cell wants to merge 1 commit into
jonathanwxh-cell wants to merge 1 commit into
Conversation
jonathanwxh-cell
marked this pull request as ready for review
October 16, 2026 05:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2199.
A failed marked-board update currently aborts the loop, leaving later boards untouched. A failed marked-board create instead logs the error and resolves. Continue through independent marked boards in both cases, then reject with one error whose
failuresarray identifies each failed board, operation, and underlying error. Successful updates still clear their flags; failed flags and existing PENDING metadata remain intact.Await the marked-board pass in the parent/child cascade caller and stop rewrapping exceptions in both cascade callers so failure details reach the caller instead of being dropped or rejected in the background. This does not add the global partial-success UI/state from #2196.
Tests use real Redux reducers with mocked API responses. Two regression cases fail on the original code: later updates are skipped, and create failures are silently resolved. Additional cases cover a fully successful batch and failure propagation through both cascade callers. The final focused run passes 175 tests across three action/reducer/regression suites on Node 22.23.2. Prettier, whitespace checks, and the commit hook pass.
All repository checks pass on af45f52: CircleCI build 6685 (63 suites, 439 tests, 65 snapshots), Codacy, and Snyk. No live-account synchronization or device/browser end-to-end test was performed.