Repository navigation
refactor(board): make recursive copy fallback explicit - #2370
Open
jonathanwxh-cell wants to merge 1 commit into
Open
jonathanwxh-cell wants to merge 1 commit into
jonathanwxh-cell wants to merge 1 commit into
Conversation
jonathanwxh-cell
marked this pull request as ready for review
October 16, 2026 04:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2362.
Recursive board copying currently relies on the misspelled
err.resposecondition to fall back to a cached child board on API errors. Remove that condition in both current-master implementations and make the existing fallback explicit. Correcting only the spelling would instead stop copying cached children on 401/500 responses.Add shared, parameterized tests that exercise both container methods: network/404/401/500 failures still copy the local child and retarget the parent's link; a successful fetch uses the remote child; an unavailable child without a cached copy does not prevent copying a later sibling. Export the Communicator container by name so the same tests exercise it directly.
Validation on Node 22.23.2:
git diff --check, and the commit hook pass.The tests use mocked API responses and local/guest copy state; no browser/backend end-to-end run was performed for this behavior-preserving cleanup.
This PR targets current master. #2293 moves the Communicator implementation into
hooks/useBoardCrud.js, so the same cleanup will need to be carried over if that refactor lands first. I asked about ownership and the preferred target branch in #2362 before preparing this change.