Skip to content

fixes to scene_prep_utils.py#353

Draft
krrishj18 wants to merge 1 commit into
mainfrom
scene-prep-big-fix
Draft

fixes to scene_prep_utils.py#353
krrishj18 wants to merge 1 commit into
mainfrom
scene-prep-big-fix

Conversation

@krrishj18
Copy link
Copy Markdown
Collaborator

What features did you add and/or bugs did you address?

  • Which GitHub issue does this address?

  • Additional description if not fully described in the GitHub issue

  • Please add videos and images to demonstrate the feature. Please upload videos to somewhere persistent (e.g. YouTube or Vimeo) for archival purposes.

How did you implement it?

  • Algorithm details, design decisions, engineering notes, and any other relevant information about the implementation should be included

How do you run and use it?

  • What commands and button presses do you use to manually launch the stack to use your new feature?

  • Write a detailed procedure with EXACT BASH COMMANDS so that another maintainer can replicate and understand the benefits of your feature, and reproduce the videos and images you added above.

Testing with PyTest

  • What pytests did you add to ensure the feature is reliable and robust? What metrics are used?

  • What's the exact command to run the pytests that test your feature? i.e. airstack test -m ...

  • What are the expected results of the tests? What should a maintainer look at to understand whether the test succeeded?

Documentation

  • Was mkdocs.yml updated? (y/n)

  • Do the docs have sufficient scope such that a newcomer can easily reproduce and use your feature?

  • Is there sufficient visual media?

Versioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant