fixes to scene_prep_utils.py#353
Draft
krrishj18 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What features did you add and/or bugs did you address?
Which GitHub issue does this address?
Additional description if not fully described in the GitHub issue
Please add videos and images to demonstrate the feature. Please upload videos to somewhere persistent (e.g. YouTube or Vimeo) for archival purposes.
How did you implement it?
How do you run and use it?
What commands and button presses do you use to manually launch the stack to use your new feature?
Write a detailed procedure with EXACT BASH COMMANDS so that another maintainer can replicate and understand the benefits of your feature, and reproduce the videos and images you added above.
Testing with PyTest
What pytests did you add to ensure the feature is reliable and robust? What metrics are used?
What's the exact command to run the pytests that test your feature? i.e.
airstack test -m ...What are the expected results of the tests? What should a maintainer look at to understand whether the test succeeded?
Documentation
Was mkdocs.yml updated? (y/n)
Do the docs have sufficient scope such that a newcomer can easily reproduce and use your feature?
Is there sufficient visual media?
Versioning
.envfile according to semantic versioning?