Repository navigation
feat(audit): expected outcomes per rule and viewport for tree, page and inline rules (#778) - #814
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #778 (does not close it).
What
audit_scope.requested_rulesnow lists every rule the run must account for with its viewports — shared, AX-tree (newengine::TREE_RULEStable, the engine runs exactly it), page (PAGE_RULESexecutor and concrete ids) and inline rules (reflow, HTML content model; mobile only). The set is derived inwcag::expectationfrom the registrations, level and[rules]filter — no second list.audit_scope.wcag_levelis new. Breaking vs. the unreleased 2.0 foundation: sample scope, coverage, session policy, snapshot fingerprint (#791 #778 #787 #790) #813 shape:requested_rulesentries are{rule_id, viewports}objects, not strings.requested_rule_outcome(missing per viewport),rule_outcome_duplicate,rule_outcome_above_level.expectation::check_unit/count_checks) forfailed_rule_checks,missing_capabilitiesandincomplete.context/on-input(static + live half) and the "not yet adopted" placeholders produced two outcomes per viewport; they now fold into one (WcagResults::fold_outcome, also used for frames). A requested html-conform check whose collection delivered nothing is an errored outcome, not a gap.Verified
cargo test(incl.rule_contract_gate,coverage_matrix, architecture ratchet),cargo clippy --all-features --all-targets -- -D warnings,cargo check --all-features; live--fullaudit of a local page passes validation (172 requested rules, 366 outcomes, no duplicates).Still open in #778
Stateaxes of the "per module, rule, subcheck, viewport and state" matrix (journeys, states from [2.0][U22] Interaktion und Sessionzustand sind kein abgeschlossener Messvertrag #787).ranoutcome for a filtered-out tree/page rule is not detected.