Repository navigation
.github/workflows: Migrate workflows to Blacksmith runners - #16
Merged
Merged
Conversation
Two issues caught by CI on the Blacksmith migration PR: 1) Mod tidy drift. PR #10 (logger + fang) shipped go.mod with charmbracelet/fang as `// indirect` even though main.go imports it directly, plus go.sum carried orphan entries from the cellbuf@latest upgrade (old ansi/cellbuf/term/displaywidth/uax29 versions, two old colorprofile versions). `go mod tidy` cleans both up. The new mod-tidy CI check did exactly what it was added to do — caught the leftover hygiene before it could mask a real dep issue down the line. 2) Check-name drift from the Blacksmith migration. The wizard rewrote `windows-latest` -> `blacksmith-4vcpu-windows-2025` in matrix.os, which propagates into the job name `Test (...)` and therefore the GitHub check-run name. Main's branch protection ruleset requires the literal name `Test (windows-latest)` — so if this PR merged as-was, every future PR would be silently blocked by a required check that no workflow run ever produces. Fix: split matrix.os (stable label that drives the job name and ruleset matching) from matrix.runner (the actual runs-on value that can change). Same trick lets matrix Linux finally benefit from Blacksmith too — the wizard left it on GitHub-hosted ubuntu while moving the standalone jobs (mod-tidy, lint, goreleaser) to Blacksmith. After this commit: - Job names stay `Test (ubuntu-latest)` / `Test (macos-latest)` / `Test (windows-latest)` regardless of runner provider. - Linux matrix runs on Blacksmith. - macOS stays on GitHub-hosted (Blacksmith doesn't offer macOS). - Windows runs on Blacksmith. - Ruleset needs no change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To whomever may be reviewing this PR,
Blacksmith is the fastest way to run your GitHub Actions.
What does this PR change?
This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:
runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.FAQ
Need help on this PR? Tag
@codesmithwith what you need.