Repository navigation
ci: harden checks before Blacksmith migration - #11
Merged
Merged
Conversation
Four additions worth bundling now so the YAML migration to Blacksmith.sh runners is a single pass: 1. Tests now run on all 3 platforms (was: ubuntu only). Pair flow touches os.UserHomeDir/filepath.Join — Windows-specific path bugs would have slipped past the prior config. Combined the old `test` and `build-matrix` jobs into a single matrix that does vet + test + build per platform. 2. New `mod-tidy` job catches go.mod/go.sum drift. Today's cellbuf/ ansi version skew (between charmbracelet/log v1 and fang v1) was exactly the failure mode this guards. 3. New `goreleaser-check` job validates .goreleaser.yml syntax on every PR. Cheap (~15s) insurance against shipping a tag that immediately breaks the release pipeline. 4. New .github/dependabot.yml: weekly bumps for gomod (grouped charmbracelet pkgs into one PR to avoid noise) + github-actions ecosystems. Public CLI; dep hygiene matters before strangers start installing. Lint job unchanged. CodeQL stays repo-settings-only. Naming: "Test (ubuntu-latest)" / "Test (macos-latest)" / "Test (windows-latest)" / "Mod Tidy Drift" / "GoReleaser Config" / "Lint" — explicit names so branch protection rulesets can require them by exact match. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Reference JSON for the GitHub Rulesets API. Solo-dev friendly:
- Require PR before merge (0 required reviewers — Brad self-approves)
- Require all 7 status checks pass (3 platform tests + mod tidy +
goreleaser check + lint + CodeQL)
- strict policy: branches must be up to date before merge
- Block force-push + deletion (absolute safety, no bypass)
- Allow merge + squash methods (rebase off; preserves clear history
trail in `git log --merges`)
- No bypass actors — rules apply uniformly. If anything ever needs
to bypass (hotfix scenario), edit via UI.
Apply with:
gh api --method PUT \
repos/captured-ventures/rememberize-cli/rulesets \
--input .github/rulesets/main-protection.json
Or POST to /rulesets to create new (the above PUT-by-name doesn't
exist; use POST then capture the returned ID for future updates).
Dashboard alternative: Settings → Rules → Rulesets → Import.
Lives in the repo as version-controlled reference. Editing the file
does NOT automatically reapply — re-run the API call after edits.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four additions worth bundling now so the YAML migration to Blacksmith.sh runners is a single pass:
Tests now run on all 3 platforms (was: ubuntu only). Pair flow touches `os.UserHomeDir` / `filepath.Join` — Windows-specific path bugs would have slipped past the prior config. Combined the old `test` and `build-matrix` jobs into one matrix that does vet + test + build per platform.
New `mod-tidy` job catches `go.mod`/`go.sum` drift. Today's cellbuf/ansi version skew (between charmbracelet/log v1 and fang v1) was exactly the failure mode this guards.
New `goreleaser-check` job validates `.goreleaser.yml` syntax on every PR. Cheap (~15s) insurance against shipping a tag that immediately breaks the release pipeline.
New `.github/dependabot.yml`: weekly bumps for `gomod` (with `charmbracelet/` + `charm.land/` grouped into one PR per week to avoid noise) + `github-actions` ecosystems. Public CLI; dep hygiene matters before strangers start installing.
What didn't change
Check naming (relevant for branch protection)
After this PR, the required-check candidates are:
Plus `Analyze (go)` from CodeQL. Pinning all 7 as required is solo-dev-friendly: they're all fast and you'd want them green anyway before merging.
Verification
Test plan
Sequencing note
Open simultaneously with #10 (logger + fang re-merge). They touch disjoint paths and won't conflict regardless of merge order.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.