Skip to content

feat: add response_option_date to questionnaire - #1413

Merged
rmagier1 merged 1 commit into
release/1.349.0from
feat/questionnaire-response-date
Sep 9, 2026
Merged

feat: add response_option_date to questionnaire#1413
rmagier1 merged 1 commit into
release/1.349.0from
feat/questionnaire-response-date

Conversation

@miguelquintas

Copy link
Copy Markdown
Contributor

@aws-amplify-us-west-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1413.d298pum72820gn.amplifyapp.com

@miguelquintas
miguelquintas force-pushed the feat/questionnaire-response-date branch from d97a5ed to 5feaa07 Compare September 7, 2026 13:55
@canvas-sisyphus

Copy link
Copy Markdown
Contributor

🔍 AWS Amplify Console Web Preview — investigation i-aws-amplify-console-web-preview

#### AWS Amplify Console Web Preview failed — not caused by this diff — heading, then tight.

Let me write the deliverable.


AWS Amplify Console Web Preview failed — the diff isn't the cause

Amplify's preview build is the only red check; all four test-code (3.11–3.14) jobs are green. Those jobs run test-code-blocks.py over doc code blocks and never build the site, so a prose/table edit like this one is only ever exercised by Amplify's yarn build (webpack → jekyll buildgenerate-llms.py).

Root cause: Can't be read from here — Amplify is an external check, not a GitHub Actions run, so its build log lives only in the Amplify console and isn't fetchable via the logs tool (the GitHub check-run page shows a 0s duration and no error text). Everything I can check points away from the content: the added {% include alert.html … %} at collections/_sdk/data/questionnaire.md:73 is well-formed (balanced <code> tags, no unescaped quotes) and matches ~30 existing alert.html calls, and nothing in generate-llms.py / context_extractor.py has a code path this prose/table edit would break. The Amplify preBuild/build phases are network-heavy (rvm install, gem install, curl … astral.sh | sh, bundle install, yarn install, uv run) — the usual source of a transient preview failure.

Recommended action: Re-trigger the preview — "Redeploy this version" in the Amplify console (no new commit needed) or push any trivial commit. If it fails again, paste the failing phase/command from the Amplify build log and I'll dig in — that log is the one datum I can't reach from here. (I can't re-run it for you: rerun_workflow only drives GitHub Actions, and this check isn't one.)

Separately (not CI-related): this PR documents dates as now readable, but the existing warning at collections/_sdk/data/questionnaire.md:165 still says a DATE answer "is not readable through the data module yet … response_option_value is empty." Those now contradict each other. Reply /sisyphus fix and I'll drop that stale alert.

Reply /sisyphus fix i-aws-amplify-console-web-preview to apply.


/sisyphus pause stops me from touching this PR.

@rmagier1
rmagier1 changed the base branch from main to release/1.349.0 September 9, 2026 17:47
@rmagier1
rmagier1 merged commit dc97085 into release/1.349.0 Sep 9, 2026
6 of 7 checks passed
@rmagier1
rmagier1 deleted the feat/questionnaire-response-date branch September 9, 2026 17:48
rmagier1 added a commit that referenced this pull request Sep 9, 2026
Rewrite the auto-generated notes against the merged diffs of every PR in
the release rather than the Jira Release Notes drafts.

- Drop the Internal:-prefixed Sentry-noise bullet (KOALA-6667) and the two
  "n.a." placeholders (KOALA-7156 Debian base image, KOALA-7160 note
  migration job); all three are internal.
- Add the questionnaire date-answer bullet for KOALA-7056, whose Jira
  Release Notes field read N/A but which adds a documented SDK field.
- Scope the KOALA-6860 timestamp bullet to the data views. The SDK data
  models in canvas-plugins 0.219.1 do not declare created/modified on the
  newly covered resources, so a plugin cannot read them there.
- Correct the revenue-queue bullet: insurers were grouped by having no
  payer ID, not by having similar names.
- Give KOALA-7020 the symptom customers saw (afternoon times saved as
  morning, times after midnight saved as afternoon, no time zone) and note
  that values saved earlier cannot be corrected automatically.
- Give KOALA-7145 its user-visible halves: notes holding API- or
  plugin-created commands open without a delay, and "Last modified by"
  names the most recently added editor.
- Move the requisition-form bullet out of the sdk section into bugfix.
- Add a feed_summary override; the prose overflows the Slack RSS digest.

Also remove the stale questionnaire callout saying a DATE answer is not
readable through the data module, which #1413 contradicted but left in
place, and point the DATE question-type row at response_option_date.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants