Repository navigation
Conversation
Splitting link checking out of docs-lint lets a CI workflow run it in its own job, separate from the faster code and docs linters. Link checking is slow and hits the network, so it slows down every other lint job that depends on it. docs-lint keeps running sphinx-lint, spelling, and woke. make lint still runs linkcheck, so local behaviour and the full lint target are unchanged. Co-Authored-By: Copilot <198982749+Copilot@users.noreply.github.com>
Test branch for #625. Uses the split lint-python.yaml from canonical/starflow#199 instead of starflow/main, so this branch has both halves of the change. Co-Authored-By: Copilot <198982749+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Restore the omitted non-documentation lint checks in the split workflow.
0 open findings
What changed in this PR
Tests Starbase compatibility with Starflow’s split lint workflow before it reaches main.
Changes:
- Adds the standalone
docs-linkchecktarget. - Includes documentation link checking in aggregate linting.
- Points QA to Starflow’s compatibility branch.
| File | Summary |
|---|---|
Makefile |
Includes documentation link checking in aggregate linting. |
common.mk |
Defines the standalone documentation link-check target. |
.github/workflows/qa.yaml |
Uses Starflow’s split workflow; its lint-code job omits existing non-documentation checks. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lengau
added this pull request to stack #629
October 15, 2026 00:06
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Forwards compatibility test for #625. Not intended to merge.
This branch is #625 plus one extra commit that points the
lintjob atcanonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheckinstead of
@main.That gives both halves of the change at once:
docs-linkchecktarget (ci(lint): improve CI UX when splitting linter jobs #625)code,docs, andlinkcheckas separate jobs(ci(lint-python): split linting into code, docs, and linkcheck jobs starflow#199)
What it tests
Whether a downstream repo works when it picks up the starbase change before
starflow's split workflow reaches
main.Stacked on this
Docs-only filter test: #628
Related