Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Signed EFI installs may omit the font, and dedicated-boot font coverage is missing.
1 open finding
What changed in this PR
Stages the guest’s GRUB Unicode font so boot menus render glyphs correctly.
Changes:
- Copies
unicode.pf2into the staged GRUB fonts directory. - Adds BIOS staging test coverage.
| File | Summary |
|---|---|
imagecraft/pack/bootloader/staging.py |
Adds Unicode font staging; signed EFI installs still require coverage. |
tests/unit/pack/bootloader/test_bios.py |
Verifies default boot-directory font staging; dedicated-boot coverage is incomplete. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lengau
marked this pull request as ready for review
October 20, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage the guest's unicode.pf2 font next to the staged GRUB modules so the bootloader menu renders glyphs correctly.