Repository navigation
Conversation
LoweRAM
force-pushed
the
add-lint-code-target
branch
from
October 25, 2026 15:38
6b04479 to
d5c7f53
Compare
LoweRAM
changed the title
lengau
marked this pull request as ready for review
October 25, 2026 15:42
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The advertised docs, twine, and uv-lockfile linters are not wired into lint, leaving a moderate unresolved issue.
No open issues 🎉
What changed in this PR
This pull request adds a lint-code Makefile target for code-specific linters and updates lint to depend on it.
Changes:
- Adds the
lint-codetarget for golangci-lint and ShellCheck. - Updates
lintto depend onlint-code. - Verifies target expansion with
make -n.
| File | Description |
|---|---|
Makefile |
Adds the code-linter grouping target and updates the main lint target. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
lint-codeMakefile target grouping code-specific linters, following the starbase pattern.lintnow depends onlint-codeplus non-code linters (docs/twine/uv-lockfile where present).Verified with
make -n lint-code(andmake -n lint) in a fresh worktree from origin/main.