Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates github.com/elazarl/goproxy to v1.9.2 and aligns the MITM URL test with normalized host behavior.
Changes:
- Bumps the
goproxydependency. - Updates module checksums.
- Adjusts the proxy test’s expected HTTPS URL.
| File | Description |
|---|---|
proxy/proxy_test.go |
Reflects normalized URL host behavior. |
go.sum |
Adds v1.9.2 checksums. |
go.mod |
Updates goproxy to v1.9.2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bepri
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
github.com/elazarl/goproxytov1.9.2and updatesproxy/proxy_test.goto matchgoproxy's normalizedreq.URL.Hostbehavior in MITM mode (introduced in goproxy v1.9.1).Supersedes #644.