Repository navigation
fix: align strip helper options with dh_strip - #212
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Classification must use file mode bits to match dh_strip.
1 open issue
What changed in this PR
Aligns the strip helper’s options and executable/library handling with dh_strip.
Changes:
- Removes
.commentand.notesections. - Applies library-specific stripping behavior.
- Expands unit coverage for executables and libraries.
A moderate issue remains: file classification uses os.access(..., os.X_OK) instead of mode bits, which can diverge from dh_strip.
| File | Description |
|---|---|
tests/unit/helpers/test_strip.py |
Tests executable and library strip options. |
debcraft/helpers/strip.py |
Updates strip command construction and file classification. |
Review effort: Lite
bepri
marked this pull request as ready for review
October 19, 2026 19:11
lengau
approved these changes
Oct 19, 2026
mr-cal
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

make lint && make test?Fixes #198
DEBCRAFT-87