Skip to content

fix: align strip helper options with dh_strip - #212

Merged
bepri merged 3 commits into
mainfrom
work/dh-strip-args/DEBCRAFT-87
Oct 20, 2026
Merged

bepri merged 3 commits into
mainfrom
work/dh-strip-args/DEBCRAFT-87

Conversation

@bepri

@bepri bepri commented Oct 19, 2026

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

Fixes #198
DEBCRAFT-87

@bepri bepri self-assigned this Oct 19, 2026
Copilot AI lite review requested due to automatic review settings October 19, 2026 18:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Classification must use file mode bits to match dh_strip.

1 open issue
What changed in this PR

Aligns the strip helper’s options and executable/library handling with dh_strip.

Changes:

  • Removes .comment and .note sections.
  • Applies library-specific stripping behavior.
  • Expands unit coverage for executables and libraries.

A moderate issue remains: file classification uses os.access(..., os.X_OK) instead of mode bits, which can diverge from dh_strip.

File Description
tests/​unit/​helpers/​test_strip.py Tests executable and library strip options.
debcraft/​helpers/​strip.py Updates strip command construction and file classification.

Review effort: Lite

Comment thread debcraft/helpers/strip.py Outdated
@bepri
bepri marked this pull request as ready for review October 19, 2026 19:11
@bepri
bepri requested a review from a team October 19, 2026 19:11
@bepri
bepri requested a review from a team October 19, 2026 19:25
@bepri
bepri merged commit 3b307ff into main Oct 20, 2026
18 checks passed
@bepri
bepri deleted the work/dh-strip-args/DEBCRAFT-87 branch October 20, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align strip helper options with dh_strip

4 participants