Repository navigation
Conversation
Points the lint job at `canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck` to exercise the lint workflow being reworked in canonical/starflow#199. That change splits the lint workflow into separate jobs and renames the `lint` make target to `lint-code`. This repository already provides `lint-code`, `docs-lint`, and the `docs-%` passthrough that supplies `docs-linkcheck`, so the workflow reference is the only edit needed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - '!({docs/**,*.md,**/*.md,.readthedocs.yaml})' | ||
| lint: | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@main | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck |
There was a problem hiding this comment.
🔵 Needs a closer look
The temporary workflow branch requires final human verification before approval.
0 open findings
What changed in this PR
Updates the QA workflow to test Starflow’s split lint workflow.
Changes:
- References
work/separate-linkcheck. - Preserves the existing
source-filesinput.
| File | Description |
|---|---|
.github/workflows/qa.yaml |
Points the lint workflow to the integration-test branch. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Status of this integration test for canonical/starflow#199 is recorded in a table in that pull request. The These come from the Reported files, none of them modified here: |
|
Closing: integration test of canonical/starflow#199 complete. Results recorded in canonical/starflow#199. |
Summary
Points the lint job at
canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheckto exercise the lint workflow that is being reworked in canonical/starflow#199.That change splits the lint workflow into separate jobs and renames the
lintmake target tolint-code:filterfilesmake -k lint-codedocsmake -k docs-lintlinkcheckmake -k docs-linkcheckThis repository already provides
lint-code,docs-lint, and thedocs-%passthrough that suppliesdocs-linkcheck, so the workflow reference is the only edit needed.Scope
Workflow reference only. No make target and no source changes.
The
docsandlinkcheckjobs are expected to be skipped on this pull request, because it touches no documentation. They are exercised by pull requests that changedocs/, Markdown, or reStructuredText files.Relationship to canonical/starflow#199
This pull request is an integration test for canonical/starflow#199. It should not be merged before that one lands, and the reference should be moved back to
mainafterwards.Each repository that is testing this branch is listed in the table on canonical/starflow#199.