Repository navigation
ci: restore osv-scanner configuration in policy workflow - #508
Closed
dangertoaster wants to merge 1 commit into
Closed
dangertoaster wants to merge 1 commit into
dangertoaster wants to merge 1 commit into
Conversation
The python-scans job lost its permissions block and its entire 'with' configuration (osv-exclude-paths, uv-export-no-groups), so OSV-scanner runs without the docs exclusions. The scanner then resolves the unpinned specifiers in docs/requirements.txt at their minimum versions and reports vulnerabilities (anyio, h11, idna) in versions that are never actually installed. Restore the docs exclusions, matching how snapcraft and charmcraft configure the same reusable workflow.
This was referenced Oct 16, 2026
Contributor
Author
|
🤖 [BEEP BOOP, A BOT WROTE THIS COMMENT - kimi-k3, opencode] Closing as unnecessary — the starbase merge PR (#507) already restores the complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This message was generated by kimi-k3.
Problem
The
python-scansjob in.github/workflows/policy.yamllost itspermissionsblock and its entirewith:configuration, so the OSV-scanner runs withOSV_EXCLUDE_PATHSempty. It then scansdocs/requirements.txt, and because the docs groups are also absent fromuv-export-no-groups, resolves the unpinned specifiers (e.g.sphinx-autobuild) at their minimum satisfying versions — flagging vulnerabilities inanyio 4.9.0,h11 0.9.0, andidna 3.9.0, none of which are ever actually installed (the uv.lock already contains fixed versions of all three).This currently fails the
Security scan / OSV-scannercheck on unrelated PRs (e.g. #505, #506).Fix
Restore the missing
permissionsandwith:blocks, excludingdocsfrom the OSV scan and the docs dependency groups from theuv export— matching how snapcraft and charmcraft configure the same reusablecanonical/starflow/scan-python.yamlworkflow. The docs requirements are development-only tooling, not shipped artifacts.Validation
OSV_EXCLUDE_PATHS: docstaking effect (--experimental-exclude docs).OSV_EXCLUDE_PATHS:empty — this PR restores exactly that input.Provenance
Discovered while validating preparation PRs for the Starbase sync (#507), where the starbase-provided
policy.yamlincludes this configuration by default. The exact exclusion set (docsonly, notests/spread) matches this repository's structure — craft-cli has no spread tests.