Repository navigation
Conversation
Points the lint job at `canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck` to exercise the lint workflow being reworked in canonical/starflow#199. That change splits the lint workflow into separate jobs and renames the `lint` make target to `lint-code`. This repository already provides `lint-code`, `docs-lint`, and the `docs-%` passthrough that supplies `docs-linkcheck`, so the workflow reference is the only edit needed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| jobs: | ||
| lint: | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@main | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The referenced workflow is incompatible with the repository’s current lint targets.
2 open findings
What changed in this PR
Updates the QA workflow to test Starflow’s split lint workflow branch.
Changes:
- Points the reusable lint workflow at
work/separate-linkcheck. - Makes no source or Makefile changes.
| File | Summary | Findings |
|---|---|---|
.github/workflows/qa.yaml |
Updates the reusable lint workflow reference. | Critical (4 votes): lint-code is missing, so source-change builds fail. Moderate (3 votes): docs-lint still runs link checking, causing duplicate checks. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| jobs: | ||
| lint: | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@main | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck |
| jobs: | ||
| lint: | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@main | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck |
The starflow lint workflow is being split so that the code linters run as their own job, and it calls the code linters as `make -k lint-code` (see canonical/starflow#199). Split the aggregate `lint` target so the code linters can be addressed as `lint-code`, matching the repositories that already provide it. `lint` still runs everything for local use.
dangertoaster
added a commit
to dangertoaster/craft-cli
that referenced
this pull request
Oct 16, 2026
This is a mandatory document for all projects.
Contributor
Author
|
Closing: integration test of canonical/starflow#199 complete. Results recorded in canonical/starflow#199. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points the lint job at
canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheckto exercise the lint workflow that is being reworked in canonical/starflow#199.That change splits the lint workflow into separate jobs and renames the
lintmake target tolint-code:filterfilesmake -k lint-codedocsmake -k docs-lintlinkcheckmake -k docs-linkcheckThis repository had no
lint-codetarget, so the aggregatelinttarget is split to match the repositories that already provide it.lintstill runs everything for local use.Scope
Workflow reference and
Makefileonly. No source changes.The
docsandlinkcheckjobs are expected to be skipped on this pull request, because it touches no documentation. They are exercised by pull requests that changedocs/, Markdown, or reStructuredText files.Relationship to canonical/starflow#199
This pull request is an integration test for canonical/starflow#199. It should not be merged before that one lands, and the reference should be moved back to
mainafterwards.Each repository that is testing this branch is listed in the table on canonical/starflow#199.