Repository navigation
style: resolve ty type-checking errors in config service - #1231
Merged
Merged
Conversation
lengau
marked this pull request as ready for review
October 22, 2026 18:58
bepri
approved these changes
Oct 22, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The suppressions may hide a runtime-invalid default-factory call and an inaccurate _convert_type typing contract.
1 open issue
What changed in this PR
This pull request addresses ty type-checking diagnostics in the configuration service caused by updated dependency signatures.
Changes:
- Adds a suppression for the default-factory missing-argument diagnostic.
- Adds a suppression for the field-annotation argument-type diagnostic.
| File | Description |
|---|---|
craft_application/services/config.py |
Adds targeted ty suppressions for Pydantic default-factory invocation and field-annotation conversion; review comments identify a potentially unsupported factory signature and an inaccurate helper type contract. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolve
ty checkdiagnostics incraft_application/services/config.pyintroduced by updated type signatures in dependencies:missing-argumentforfield.default_factory()where union signature includes(dict[str, Any], /) -> Any.invalid-argument-typefor passingfield_info.annotationto_convert_type.Verified by running
make lintandmake test-fast.make lint && make test.