Repository navigation
fix(lifecycle): prefer --use-lxd over CRAFT_BUILD_ENVIRONMENT - #1229
Merged
lengau merged 3 commits intoOct 23, 2026
Merged
Conversation
jkomalley
marked this pull request as ready for review
October 22, 2026 03:27
jahn-junior
reviewed
Oct 22, 2026
bepri
approved these changes
Oct 22, 2026
Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com> Signed-off-by: Kyle O'Malley <36799542+jkomalley@users.noreply.github.com>
jahn-junior
self-requested a review
October 22, 2026 23:51
jahn-junior
approved these changes
Oct 22, 2026
Collaborator
|
Bypassing flaky test failure (each spread test did succeed, though not all together). Thanks again @jkomalley ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
--use-lxdnow runs the build in managed mode even whenCRAFT_BUILD_ENVIRONMENT=hostis set. I added the check to_use_provider, updated/added to the parameters for the existing_use_providertests, and added a little blurb about it to the docs.Fixes #354
make lint && make test.