Skip to content

fix(lifecycle): prefer --use-lxd over CRAFT_BUILD_ENVIRONMENT - #1229

Merged
lengau merged 3 commits into
canonical:mainfrom
jkomalley:issue-354-prefer-use-lxd-over-build-env
Oct 23, 2026
Merged

lengau merged 3 commits into
canonical:mainfrom
jkomalley:issue-354-prefer-use-lxd-over-build-env

Conversation

@jkomalley

@jkomalley jkomalley commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Passing --use-lxd now runs the build in managed mode even when CRAFT_BUILD_ENVIRONMENT=host is set. I added the check to _use_provider, updated/added to the parameters for the existing _use_provider tests, and added a little blurb about it to the docs.

Fixes #354


  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test.
  • I've added or updated any relevant documentation.
  • In documents I changed, I added a meta description if one was missing.
  • I've updated the relevant release notes.

@jkomalley
jkomalley marked this pull request as ready for review October 22, 2026 03:27
@jkomalley
jkomalley requested review from a team and lengau as code owners October 22, 2026 03:27

@lengau lengau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lengau
lengau requested a review from a team October 22, 2026 18:03

@jahn-junior jahn-junior left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! (and bonus points for adding a meta description)

I left a few minor wording suggestions for the docs changes, but that should be all before this is ready for merge.

Comment thread docs/reference/changelog.rst Outdated
Comment thread docs/reference/environment-variables.rst Outdated
Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com>
Signed-off-by: Kyle O'Malley <36799542+jkomalley@users.noreply.github.com>
@jahn-junior
jahn-junior self-requested a review October 22, 2026 23:51
@lengau
lengau merged commit 46a9b79 into canonical:main Oct 23, 2026
28 of 30 checks passed
@lengau

lengau commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Bypassing flaky test failure (each spread test did succeed, though not all together).

Thanks again @jkomalley !

@jkomalley
jkomalley deleted the issue-354-prefer-use-lxd-over-build-env branch October 23, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefer --use-lxd over CRAFT_BUILD_ENVIRONMENT

4 participants