WD-38664 Refresh canonical.com/data/opensearch - #2946
Open
jademathre-canonical wants to merge 1 commit into
Open
jademathre-canonical wants to merge 1 commit into
jademathre-canonical wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
==========================================
+ Coverage 75.84% 75.89% +0.04%
==========================================
Files 20 20
Lines 2596 2605 +9
==========================================
+ Hits 1969 1977 +8
- Misses 627 628 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
/data/opensearchto the new copy doc, following the Cassandra / etcd / Kafka data page pattern:/data/servicesData | Services | Docs, matching Kafka and the designmatchkey to secondary-navigation bubbles (webapp/navigation.py) so two bubbles can sharepath: /datawithout matching each other's pages; scoped thekafkaandopensearchbubbles with it/data/servicesno longer picks up Kafka's bubble and Docs link; it now falls back to the generic Data bubblematchscoping intests/test_navigation.pyDeviations from the copy doc
[Tell us more about your needs]). The page renders it as a text link in the resources list, opening the contact modal, because that is how the Kafka page renders the same CTA and the section uses the shared resources macro. The data spotlight CTAs (Contact us ›,Check our automation ›,Try it yourself ›) are also bracketed in the copy doc but are text links, matching the data spotlight pattern on every sibling page.QA
dotrun/data/opensearchand compare against the Figma design and the copy doc:/data/opensearchand its subpages (/what-is-opensearch,/managed,/support,/docs) showData | Services | Docs, with Docs linking to/data/opensearch/docs/data/kafkastill showsData | Services | Docswith Docs linking to/data/kafka/docs/4/data/servicesnow showsData | Portfolio | Services(previously it showed Kafka's Docs link)/data/cassandraand/data/etcdare unchangedpython3 -m unittest tests.test_navigationandyarn run lint-pythonandyarn run lint-htmlIssue / Card
WD-38664
Screenshots