chore(deps): require prettier ^3.9.9 - #25
Merged
Merged
Conversation
CI installs the newest prettier, so a contributor with an older one can pass `prettier --check` locally and fail in CI (3.8 and 3.9 format some code differently). Raise the floor to the version CI uses; it needs Node >= 14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9cQvMhpbKtpdV2nEdQ6cX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI installs the newest Prettier, because there is no lockfile. A contributor with an older Prettier can then pass
prettier --checklocally and fail in CI: 3.8 and 3.9 format some code differently, which is what tripped canboat/canboatjs#476.This raises the minimum to 3.9.9, the version CI uses today. It needs Node >= 14. The repo already passes
prettier --checkwith it.Same change as canboat/canboatjs#477; see SignalK/signalk-server#3114 for the case for an exact pin.
🤖 Generated with Claude Code
https://claude.ai/code/session_01K9cQvMhpbKtpdV2nEdQ6cX