Upgrade geonetwork-ui for duckdb optimization, resourceDate sort and new default basemap - #159
Conversation
85807e5 to
1f09e36
Compare
1f09e36 to
796470b
Compare
tkohr
left a comment
tkohr
left a comment
There was a problem hiding this comment.
Thanks @LHBruneton-C2C , works mostly fine !
I can't manage to open the second record from the "how to test" section which seems to be due to its size. There is also an error in the console, but it also appears on other record and on prod:
Also couldn't get the chart to work on this really small record which works on prod 🤔 :
https://data.lillemetropole.fr/catalogue/dataset/5ce5c566-871c-437b-8d85-dc37d0b66b84
Maybe some more testing with more records will be necessary!?
| "styles": ["resources/styles.css"], | ||
| "styles": [ | ||
| "resources/styles.css", | ||
| "node_modules/@angular/material/prebuilt-themes/indigo-pink.css" |
There was a problem hiding this comment.
This may also be needed in the home app.
There was a problem hiding this comment.
Thanks, I'll add it to be sure.
| const SORT_BY_RESOURCE_DATE: SortByField = ['desc', 'resourceDate.date'] | ||
|
|
||
| const SORT_BY_METADATA_DATE: SortByField = [['desc', 'createDate']] | ||
| const SORT_BY_METADATA_DATE: SortByField = ['desc', 'createDate'] |
There was a problem hiding this comment.
Didn't test by creating new datasets, but I see that the sorts are different for the existing ones.
| cy.intercept( | ||
| 'POST', | ||
| `/geonetwork/srv/api/search/records/_search?bucket=bucket&relatedType=fcats&relatedType=hassources`, | ||
| `/geonetwork/srv/api/search/records/_search?bucket=bucket&relatedType=fcats&relatedType=hassources&relatedType=siblings&relatedType=associated`, |
| "overrides": { | ||
| "geonetwork-ui": { | ||
| "@camptocamp/ogc-client": "1.3.1-dev.bb345f0" | ||
| } |
There was a problem hiding this comment.
Didn't see this mentioned in the PR description, but I guess it's on purpose thanks to the gn-ui update.
There was a problem hiding this comment.
Yep, blaming this line, you can see that the PR adding it already mentionned it could be removed as soon as geonetwork-ui is updated ;)
It's not working on prod for me: I'll try another small one just to be sure. With https://data.lillemetropole.fr/catalogue/dataset/cfe9a2dc-e308-4b01-9ebd-5cd1209a0ff3: |
796470b to
148aff7
Compare
tkohr
left a comment
tkohr
left a comment
There was a problem hiding this comment.
Ok the other records I had tested quickly also worked for me, so I'll approve.
148aff7 to
b582550
Compare
b582550 to
d3f695c
Compare
LHBruneton-C2C
changed the title
2 participants
Description
This PR pulls the latest version on geonetwork-ui, with:
resourceDate.datesortThe previous version was already a dev version, pulled on May the 7th.
Features merged in between affecting DataMEL:
e2e fixes:
Screenshots
Angular Material correctly displaying the tabs + spatial extent in the preview + new basemap:
Quality Assurance Checklist
breaking changelabelbackport <release branch>labelHow to test
For large datasets:
For the sort, see the "how to test" of geonetwork/geonetwork-ui#1684.
Make sure the initial sort is correctly set on most recent.