Skip to content

refactor: tweak occasionally failing nightly test #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdjastrzebski merged 1 commit into from
Oct 5, 2026
Merged

refactor: tweak occasionally failing nightly test #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/user-event/press/__tests__/press.real-timers.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ import { userEvent } from '../..';
import { render, screen } from '../../..';
import { createEventLogger, getEventsNames } from '../../../test-utils/events';

// Typical event order is pressIn, pressOut, press
// But sometimes due to a race condition, the order is pressIn, press, pressOut.
const VALID_PRESS_ORDERS = ['pressIn, pressOut, press', 'pressIn, press, pressOut'];

describe('userEvent.press with real timers', () => {
beforeEach(() => {
jest.useRealTimers();
Expand All @@ -34,12 +38,8 @@ describe('userEvent.press with real timers', () => {
);

await user.press(screen.getByTestId('pressable'));
// Typical event order is pressIn, pressOut, press
// But sometimes due to a race condition, the order is pressIn, press, pressOut.
const eventSequence = getEventsNames(events).join(', ');
expect(
eventSequence === 'pressIn, pressOut, press' || eventSequence === 'pressIn, press, pressOut',
).toBe(true);
expect(VALID_PRESS_ORDERS).toContain(eventSequence);
});

test('works on TouchableOpacity', async () => {
Expand Down Expand Up @@ -204,11 +204,7 @@ describe('userEvent.press with real timers', () => {
await user.press(screen.getByTestId('pressable'));

const eventSequence = getEventsNames(events).join(', ');
// Typical event order is pressIn, pressOut, press
// But sometimes due to a race condition, the order is pressIn, press, pressOut.
expect(
eventSequence === 'pressIn, pressOut, press' || eventSequence === 'pressIn, press, pressOut',
).toBe(true);
expect(VALID_PRESS_ORDERS).toContain(eventSequence);
});

test('crawls up in the tree to find an element that responds to touch events', async () => {
Expand Down
Loading